Onebox is including protocol agnostic links incorrectly


(Sam Saffron) #1

See:

^^^

My avatar is broken


Does anyone actually like the "Likes" column?
(Sam Saffron) #2

@eviltrout can you sort this out, we got to get it fixed for v1.


(Robin Ward) #3

Hmmm after investigation it seems our opengraph headers were returning protocol relative URLs which is wrong as we can’t guarantee an installation of Discourse supports both protocols if referenced by another remote site.

I’ve fixed it in this commit:

https://github.com/discourse/discourse/commit/ee40a95e58db4c5ee6171c7fc2b2ffd0a0c707e9

And as you can see here linking to an upgraded site now works:

So as more sites upgrade and caches get cleared we’ll see this problem vanish.


(Robin Ward) #4