Oneboxes have images without dimensions


(Sam Saffron) #1

Oneboxes, like

Have images without dimensions, this means that if you load a topic that has one of these puppies the whole topic “jiggles” while loading.

Our image “grabber” should not bypass oneboxed images and should always at least grab dimensions. Otherwise oneboxes really muck with render pipeline.

Also missing here AND hotlinking image ^^^


(Rikki Tooley) #2

Why hardcode the image dimensions when you can just use a bit of CSS?


(Mittineague) #3

Maybe because of this effect?


(Rikki Tooley) #4

I don’t have any jiggle :frowning:


(Mittineague) #5

Using Firefox 30 I get one.

It happens real quick and only lasts for a mere fraction of a second right as the page loads in.
You may have missed noticing it as it is very easy to miss.


(Régis Hanol) #6

This is now done :panda_face:

https://github.com/discourse/discourse/commit/8bde0199101758397cee30e9e23c53f0a2f1141d


(Kris) #7

I was setting image sizes in CSS and had to revert because of jiggles and it was also causing some positioning issues when returning to a specific post (you’d return to post 4, images would load, and you’d be on post 6).


(Jeff Atwood) #8