큰 이미지 원박싱 실패 시 시각적 표시가 없음

Arkshine · 4월 14, 2023, 7:51오후

If you upload the image, it will be optimized before the upload happens.

Also, you can see the limit in the browser console

Let’s forget what you see here; it’s misleading with your issues.

From what I tested on your forum, posting an image link works well.
That would be welcome if you could provide another concrete example.

One thing that bothers me is why this image, for example, https://dronescene.co.uk/images/uploads/fullsize/20230227161106_DJI_0087_1.jpg is still failing on your forum (and I can’t reproduce it elsewhere)

From what I see, the cache is only 1h.

github.com/discourse/discourse

app/controllers/onebox_controller.rb

main


      
          
          # only 1 outgoing preview per user
          return render(body: nil, status: :too_many_requests) if Oneboxer.is_previewing?(current_user.id)
          
          user_id = current_user.id
          category_id = params[:category_id].to_i
          topic_id = params[:topic_id].to_i
          invalidate = params[:refresh] == "true"
          url = params[:url]
          
          return render(body: nil, status: :not_found) if Oneboxer.recently_failed?(url)
          
          hijack(info: "#{url} topic_id: #{topic_id} user_id: #{user_id}") do
            Oneboxer.preview_onebox!(user_id)
          
            preview =
              Oneboxer.preview(
                url,
                invalidate_oneboxes: invalidate,
                user_id: user_id,
                category_id: category_id,

github.com/discourse/discourse

app/controllers/onebox_controller.rb

main


      
          if preview.blank?
            Oneboxer.cache_failed!(url)
            render body: nil, status: :not_found
          else
            render plain: preview

github.com/discourse/discourse

lib/oneboxer.rb

main


      
          end
          
          def self.onebox_raw(url, opts = {})

nbianca · 4월 25, 2023, 2:48오후

There are two ways images can be oneboxed and unfortunately, only one was handled correctly. This should be fixed in:

https://github.com/discourse/discourse/pull/21237

Richie · 4월 25, 2023, 6:34오후

Thanks for looking in to this Bianca

images can be oneboxed by the AllowlistedGenericOnebox or ImageOnebox and only AllowlistedGenericOnebox was handled correctly

Are you able to tell if this bug was a regression?

Canapin · 4월 26, 2023, 12:18오후

Hi Richie

Please tell us if this change fixes your issue when it’s live.

Richie · 4월 26, 2023, 1:32오후

I’ve looked at the code changes in the commit from Bianca, looks promising

nbianca · 4월 26, 2023, 7:48오후

The fix has been merged, updating should resolve the issue on your site as well.

I think this has been a bug from day 1.

Canapin · 5월 4, 2023, 8:37오후

The fix was merged and this is what will be displayed now when we link a remote image too large to be downloaded to Discourse when download remote images to local is set to true.

글		댓글	조회수
Incorrect or failing oneboxes for links to other discourse instances Bug	16	2353	8월 17, 2017
Link image resizing issue (setting) Support	6	737	6월 3, 2021
Add setting to disable hotlinking of large image files Feature	58	7072	3월 8, 2018
Fetching images from newspaper websites is failing Support	2	610	8월 16, 2022
Missing images at Meta.discourse.org Site feedback	57	3117	6월 20, 2026

큰 이미지 원박싱 실패 시 시각적 표시가 없음

Related topics