# “Open all external links in a new tab” option does not work for protocol agnostic links

**URL:** https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224
**Category:** Bug
**Created:** [8 أبريل 2016، 6:58ص UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224 "2016-04-08T06:58:00Z")
**Posts on this page:** 11
**Page:** 2

<div class="post-metadata">

### Author: ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [11 أبريل 2016، 1:37م UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/21 "2016-04-11T13:37:16Z")

</div>

> [@jesus2099](#):
>
> See ? It’s this same post that I was using to know when it will work.Neither github nor MusicBrainz external links do work indeed from that post.

This is easy to reproduce now.

[http://try.discourse.org/t/open-links-in-external-window-test/344](http://try.discourse.org/t/open-links-in-external-window-test/344)

It is because the first two links are using protocol agnostic URLs, they do not start with http: or https: and instead start with //

[try.discourse.org](http://try.discourse.org) is temporary, so here is the code to reproduce the issue

```plaintext
[MusicBrainz's community](//community.metabrainz.org/t/do-i-have-to-hit-the-save-button-after-scanning-music-in-picard/20489/3?u=jesus2099) - won't open in new window.

[Discourse 1.6.0.beta1](//github.com/discourse/discourse/commit/1481b3420ec1fa8514a9f37ec8947d91b9642731) - won't open in a new window

------------------------

[MusicBrainz's community](https://community.metabrainz.org/t/do-i-have-to-hit-the-save-button-after-scanning-music-in-picard/20489/3?u=jesus2099) - will open in new window.

[Discourse 1.6.0.beta1](https://github.com/discourse/discourse/commit/1481b3420ec1fa8514a9f37ec8947d91b9642731) - will open in a new window

```

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [11 أبريل 2016، 7:50م UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/22 "2016-04-11T19:50:20Z")

</div>

Finally, an actual bug! It is a miracle 👼

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [11 أبريل 2016، 7:59م UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/23 "2016-04-11T19:59:49Z")

</div>

Ok, let’s see how hard this one is 😉

🐛 🔫

**EDIT:** Just pushed a fix

[https://github.com/discourse/discourse/commit/6ee11adf58d247d004ed838520d99281ce6426cb](https://github.com/discourse/discourse/commit/6ee11adf58d247d004ed838520d99281ce6426cb)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [11 أبريل 2016، 8:27م UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/24 "2016-04-11T20:27:01Z")

</div>



---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [11 أبريل 2016، 9:54م UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/25 "2016-04-11T21:54:05Z")

</div>



---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [11 أبريل 2016، 9:55م UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/26 "2016-04-11T21:55:02Z")

</div>

Leaving this open for a bit to keep track of the spots open links in new tabs is not working.

---

<div class="post-metadata">

### Author: ![jesus2099](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jesus2099/32/119720_2.png) [@jesus2099](https://meta.discourse.org/u/jesus2099)
#### Post date: [12 أبريل 2016، 7:55ص UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/27 "2016-04-12T07:55:28Z")

</div>

> [@codinghorror](#):
>
> Finally, an actual bug! It is a miracle 👼

I can’t know if your post did include sarcasm but, FTR, if you had read carefully my bad english, this bug was presented in the two deleted topics. 🙂

Now can you tell me where the history plugin bug tracker is, so I can report the second ~~bug~~ improvement?

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [12 أبريل 2016، 8:06ص UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/28 "2016-04-12T08:06:26Z")

</div>

> [@jesus2099](#):
>
> الآن، هل يمكنك إخباري أين يوجد متتبع أخطاء ملحق التاريخ، حتى أتمكن من الإبلاغ عن التحسين الثاني ~~الخطأ~~ التحسين؟

إنه ليس ملحقاً، بل جزء من النواة الأساسية. يمكنك الإبلاغ عن الأخطاء (مع خطوات مفصلة لإعادة إنتاجها) هنا في فئة #Contribute > Bug 😉

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [12 أبريل 2016، 8:33ص UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/30 "2016-04-12T08:33:54Z")

</div>



---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [12 أبريل 2016، 8:34ص UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/31 "2016-04-12T08:34:08Z")

</div>

Sorry this topic was left open incorrectly.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [12 أبريل 2016، 8:35ص UTC](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224/32 "2016-04-12T08:35:47Z")

</div>



[Previous page](https://meta.discourse.org/t/open-all-external-links-in-a-new-tab-option-does-not-work-for-protocol-agnostic-links/42224.md?page=1)
