I’m trying to improve First Contentful Paint (FCP) and Largest Contentful Paint (LCP) with these two PRs: https://github.com/discourse/discourse/pull/15440 https://github.com/discourse/discourse/pull/15441 I’m really interested in the actual impact of these changes – so please have a try and give…

The first one looks like an easy optimisation that I think makes sense, @david and @eviltrout spent time optimising this area so I will be very curious to see what they think about it. The second feels a bit more fragile long term, totally get the desire to optimise but it worries me a bit cause i…

Hi @rrit - thanks for the PRs. The first one sounds like a good improvement. Were you able to measure the performance impact? How much time does it save? As @sam said, the maintainability of the second one is a little concerning. It looks like it’s a copy/paste from the Ember source code? Did you c…

lookupView-patch Implemented now via Map instead of Array. Time spent on application boot in lookupView - for development instance: without patch: 124 ms Firefox Profiler (callstack filtered to lookupView) with patch: 9 ms Firefox Profiler (callstack filtered to lookupView) Time saved: ~…

Thanks for the patches. The second one does seem a little brittle. Are your benchmarks running in development mode or production mode? Ember has quite a different profile in both.

@david found an excellent way to fix this issue - see his comment on github . https://github.com/discourse/discourse/pull/15456 The time for calls to renderTopicListItem on webpage ‘latest’ drops from 348 ms to 201 ms in an Ember ‘production’-build. The earlier benchmarks were still running in dev…

[图片] rrit: The time for calls to renderTopicListItem on webpage ‘latest’ drops from 348 ms to 201 ms in an Ember ‘production’-build. Unfortunately I haven’t been able to replicate this large speed increase. On Firefox and Chrome (macOS) I’m not seeing any measurable improvement. Chrome spends…

I can still reproduce the performance benefits using performance API in Firefox private-mode (Linux). Testing http://localhost:4200/latest Time spent in renderTopicListItem is down to ~190 ms from ~290 ms. My Discourse testing-instance has many topics with many answers and many different authors …

[图片] rrit: Firefox private-mode (Linux). Would you mind sharing the Firefox and OS version? The 290ms number is almost 3x slower than a 2018 android device, which is a little surprising. [图片] rrit: This results in lots of elements to be rendered. Maybe this is the difference in our benc…

Proxy to meta.discourse.org Unfortunately running ember with a proxy fails for me: d/ember-cli --environment production --proxy https://meta.discourse.org http://localhost:4200/ Discourse Build Error Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: l…

The PR for the refactoring is now merged: https://github.com/discourse/discourse/commit/e6ab8f5b71efec9712b66806915a1f79d1e5998a Thanks for raising this one @rrit - it’s a nice improvement!

通过缓存原始视图模块查找来优化FCP/LCP

开发

eviltrout (Robin Ward) 2022 年1 月 4 日 18:02 6

谢谢您的补丁。第二个补丁似乎有点脆弱。

您的基准测试是在开发模式还是生产模式下运行的？Ember 在这两种模式下的性能差异很大。

话题		回复	浏览量
Defer javascript and show interim content on initial page load Development	19	3040	2022 年7 月 5 日
Upgrading Ember to 2.10 Development ember	71	11650	2016 年12 月 22 日
Google May 4th Core Update impact on Discourse forums Community Building	102	10538	2022 年7 月 5 日
Discourse not loading on legacy browsers Bug	50	6289	2022 年5 月 13 日
The State of JavaScript on Android in 2015 is... poor General	285	152549	2022 年12 月 18 日

通过缓存原始视图模块查找来优化FCP/LCP

相关话题