# Orientation fix missing in latest stable

**URL:** https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695
**Category:** Bug
**Created:** [3 בפברואר,‏ 2018,‏ 8:45am UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695 "2018-02-03T08:45:11Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [3 בפברואר,‏ 2018,‏ 8:45am UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/1 "2018-02-03T08:45:11Z")

</div>

Saturday morning is always a good moment to research weird problems.  
I suddenly see things that I’ve overlooked for a long time.

The image orientation fix seems to be missing in the stable branch.

Can you please, please backport it for 1.9.3 ?

Master:

> <https://github.com/discourse/discourse/blob/main/lib/upload_creator.rb#L44-L51>

Stable:

> <https://github.com/discourse/discourse/blob/stable/lib/upload_creator.rb#L44-L50>

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [3 בפברואר,‏ 2018,‏ 3:16pm UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/2 "2018-02-03T15:16:52Z")

</div>

Sure @zogstrip can you take a look?

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [4 בפברואר,‏ 2018,‏ 6:31pm UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/4 "2018-02-04T18:31:10Z")

</div>

I did a diff between stable 1.9.0 and tests-passed 2.0 beta1, which should be pretty much the same, and I found three more differences which should not be there.

[https://github.com/discourse/discourse/blob/stable/lib/validators/upload\_url\_validator.rb#L6](https://github.com/discourse/discourse/blob/stable/lib/validators/upload_url_validator.rb#L6)  
[https://github.com/discourse/discourse/blob/master/lib/validators/upload\_url\_validator.rb#L6](https://github.com/discourse/discourse/blob/master/lib/validators/upload_url_validator.rb#L6)

> **[Blaming discourse/lib/final\_destination.rb at stable · discourse/discourse](https://github.com/discourse/discourse/blame/stable/lib/final_destination.rb#L208-L223)**
>
> A platform for community discussion. Free, open, simple. - Blaming discourse/lib/final\_destination.rb at stable · discourse/discourse

> **[Blaming discourse/lib/final\_destination.rb at v2.0.0.beta1 · discourse/discourse](https://github.com/discourse/discourse/blame/v2.0.0.beta1/lib/final_destination.rb#L208-L218)**
>
> A platform for community discussion. Free, open, simple. - Blaming discourse/lib/final\_destination.rb at v2.0.0.beta1 · discourse/discourse

[https://github.com/discourse/discourse/blame/stable/app/assets/javascripts/discourse/templates/components/group-membership-button.hbs#L28-L31](https://github.com/discourse/discourse/blame/stable/app/assets/javascripts/discourse/templates/components/group-membership-button.hbs#L28-L31)

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [16 בפברואר,‏ 2018,‏ 5:03pm UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/5 "2018-02-16T17:03:00Z")

</div>

@zogstrip @neil do you have any plans to merge these changes back in to stable ?

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [16 בפברואר,‏ 2018,‏ 5:06pm UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/6 "2018-02-16T17:06:08Z")

</div>

Yup. Topic isn’t closed and still is assigned 😉 Just haven’t got a chance to do it yet.

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [17 במאי,‏ 2018,‏ 12:17pm UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/7 "2018-05-17T12:17:38Z")

</div>

Would it be possible to merge the image rotation bugfix back into stable before Discourse 2.0 stable is being released? It’s only a single line in `upload_creator.rb` that is still causing a lot of headaches.

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [17 במאי,‏ 2018,‏ 12:56pm UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/8 "2018-05-17T12:56:42Z")

</div>

Sorry for the delay. It’s now backported 🍌

[https://github.com/discourse/discourse/commit/82148a168f6dfe051c22faeeb56ad2e49a71d59a](https://github.com/discourse/discourse/commit/82148a168f6dfe051c22faeeb56ad2e49a71d59a)

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [17 במאי,‏ 2018,‏ 4:00pm UTC](https://meta.discourse.org/t/orientation-fix-missing-in-latest-stable/79695/9 "2018-05-17T16:00:01Z")

</div>

This topic was automatically closed after 3 hours. New replies are no longer allowed.