# Other people's private conversations in 'Suggested messages'

**URL:** <https://meta.discourse.org/t/other-peoples-private-conversations-in-suggested-messages/70111>\
**Category:** Bug\
**Created:** [2017年九月15日 13:07 UTC](https://meta.discourse.org/t/other-peoples-private-conversations-in-suggested-messages/70111 "2017-09-15T13:07:02Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![rizka](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rizka/32/79717_2.png) [@rizka](https://meta.discourse.org/u/rizka)\
**Post date:** [2017年九月15日 13:07 UTC](https://meta.discourse.org/t/other-peoples-private-conversations-in-suggested-messages/70111/1 "2017-09-15T13:07:02Z")

</div>

I just flagged a topic here on Meta as “something else”. When you do so, a private conversation between you and moderators is created. Under the discussion, there are ‘Suggested messages’ which I am not part of. I see their titles and participants. However when I click a discussion, I get a connection error so I cannot read them which is good. Under normal messages there are messages from my own messages as it should be.

---

<div class="post-metadata">

**Author:** ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)\
**Post date:** [2017年九月15日 14:24 UTC](https://meta.discourse.org/t/other-peoples-private-conversations-in-suggested-messages/70111/3 "2017-09-15T14:24:45Z")

</div>

Looks like the joins are not unnecessary after all

[https://github.com/discourse/discourse/commit/d9714c21c80ab3b8ff68a5520d8086aa8e91588f](https://github.com/discourse/discourse/commit/d9714c21c80ab3b8ff68a5520d8086aa8e91588f)

---

<div class="post-metadata">

**Author:** ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)\
**Post date:** [2017年九月15日 15:43 UTC](https://meta.discourse.org/t/other-peoples-private-conversations-in-suggested-messages/70111/4 "2017-09-15T15:43:29Z")

</div>

Fixed in

[https://github.com/discourse/discourse/commit/1a9762a9c0e830590760a63b9ddb11f17b135921](https://github.com/discourse/discourse/commit/1a9762a9c0e830590760a63b9ddb11f17b135921)

This was actually due to a combination of [PERF: Avoid unnecessary expensive joins if possible. · discourse/discourse@f3fadf4 · GitHub](https://github.com/discourse/discourse/commit/f3fadf41b7d723265094bb90203226941defce58) and [PERF: Avoid `NOT IN (\<subquery\>\>` which can get really slow. · discourse/discourse@2814819 · GitHub](https://github.com/discourse/discourse/commit/28148197d6467cdc7469409f961c00d4e32f4c41)

Added test cases to guard against regression.

Thanks for reporting @rizka

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [2017年九月15日 17:55 UTC](https://meta.discourse.org/t/other-peoples-private-conversations-in-suggested-messages/70111/5 "2017-09-15T17:55:22Z")

</div>