Over zealous hiding of plugin outlet?

dev
1

Team,

The plugin outlet: user-card-location-and website is hidden

https://github.com/discourse/discourse/blob/207b72ade18c07a5e131217b76722d6e9b926984/app/assets/javascripts/discourse/app/templates/components/user-card-contents.hbs

hasLocaleOrWebsite is false if user hasn’t entered a vanilla location or website, which hides the outlet (you can see this on the plugin outlets theme component clearly).

This seems overly zealous?

The problem for plugin Discourse-Locations, is that none of these should be necessary for you to see your map location which is attached to this plugin location (Hey, it’s another form of location!).

https://github.com/discourse/discourse/commit/bb4e965a6694710069cb11b509ebbd1c32847a5c

I wonder if you could take a look?

Thanks!!

Rob

1 Like
2

Can the locations plugin use the user-card-before-badges plugin outlet instead? Looks like that plugin outlet is always shown.

https://github.com/discourse/discourse/blob/207b72ade18c07a5e131217b76722d6e9b926984/app/assets/javascripts/discourse/app/templates/components/user-card-contents.hbs#L242

2 Likes
3

I’ll test and revert. I feared formatting impact.

2 Likes
4

It’s a little more involved, because the current code is doing all kinds of clever rearrangment of the elements.

The simplest approach is probably to override this Computed Property boolean switch with my own calc and everything should be dandy! :slight_smile:

Update: all sorted, sorry to bother you!

1 Like
5

All good, no worries.

2 Likes