phpBB3 importer: lists broken

(Joe Seyfried) #1

I have encountered another bug in the bbcode-parser: I have lists like this:

[list=1][*]Item 1
[*]Item 2
[*]Item 3

…which the import script converts to this:

*]Item 2/*:m]
*]Item 3/*:m]

I don’t actually know if it’s the first list item in the same line as the list definition, or if something else breaks the conversion.

(Joe Seyfried) #2

Whoa, I just checked ruby-bbcode-to-md - this seems to be a tough one: Should we convert this to ol/ul+li-notation first? Is a BBcode without a closing tag accepted by the converter? Can you specify an asterisk as a token? :worried:

(Gerhard Schlager) #3

Did you forget to post the trailing [/list] tag in your example?
I’ve just tested this in phpBB3 and of course this doesn’t work there either.

I’ve seen a few times that lists aren’t handled well when they get imported from phpBB3 (which should be fixed), but when the BBCode is invalid, there’s not much that can be done about it.

(Joe Seyfried) #4

Yeah - the BB-code was incomplete, I just posted the beginning, sry.

This should read:

[list][*]Item 1
[*]Item two
[*]Item 3

…or a [list=1], which doesn’t work either.

(Joe Seyfried) #5

Re-using this thread: am I the only one who suffers from broken [img]-tags after import? I’d like to disable the image downloading feature, and the BBCode-to-MD script seems to reply on this, since the translation is a simple %between%. I’d rather go for a <img src="%between% alt="image des. unavailable" /> - which should not have any negative side effects (or does the downloading code rely on a non-tagged img URL?

If this is fine, I can also submit a PR - this is a single-liner.

(Joe Seyfried) #6

@neil - could you take a look at this one for this thread:

(Neil Lalonde) #7

Thanks Joe! Our importer just got a little better.

(Joe Seyfried) #8

Glad I could help, Neil. Case closed…

(Neil Lalonde) #9