Plugin admin button broken styling

Development

AI-generated summary

Plugin admin button broken styling

The plugin admin button in the admin dashboard menu has lost its correct styling after a recent upgrade, as shown in an image provided by kgish. The issue is caused by a change in the app/assets/javascripts/admin/templates/admin.hbs file, where {{plugin-outlet "admin-menu" tagName="li"}} has been replaced with {{plugin-outlet name="admin-menu" connectorTagName="li"}} kgish.

kkish has found a workaround by unwrapping the HTML elements and using a JavaScript function to fix the styling issue. The Discourse team has been made aware of the issue, and it is hoped that a fix will be implemented soon kgish. cpradio believes this issue may be related to a recent discovery by sam.

1

Since the latest upgrade, my plugin button in the admin dashboard menu has lost the correct styling, as you can see here:

My /connectors/admin-menu/app-admin-connector.hbs template looks like this:

{{#link-to 'admin.pvda'}}{{i18n 'pvda.admin.menu_title'}}{{/link-to}}
2

I see that in the file app/assets/javascripts/admin/templates/admin.hbs the line:

{{plugin-outlet "admin-menu" tagName="li"}}

has been changed to:

{{plugin-outlet name="admin-menu" connectorTagName="li"}}
3

For those interested, this is my workaround until someone from the Discourse team fixes it.

Basically I need to unwrap the stuff inside the span like this:

<ul><span><li><a>...</a></li></span></ul>`

to this:

<ul><li>...</li></ul>

{{#link-to 'admin.pvda' id='admin-menu-pvda'}}
  {{i18n 'pvda.admin.menu_title'}}
{{/link-to}}

 api.onPageChange((url, title) => {

  // --- ADMIN PAGE --- //
  if (/\/admin\//.test(url)) {
    // Admin pages start with "/admin/*"
    let sel = '#admin-menu-pvda',
         pvda_menu_item = $(sel);
    if (pvda_menu_item.length) {
      let li = pvda_menu_item.parent();
      if (li.is("li")) {
        let span = li.parent();
        if (span.is("span")) {
          li.unwrap();
        }
      }
    }
  }
  ...
}
4

I think this is related to something @sam uncovered recently too

5

Yes, it’d be very nice if we could get this fixed.