It is my understanding that running rake qunit:test should run all of the qunit tests in Discourse, including those for any installed plugins. However, when I run the task in the docker development environment it only runs the core discourse tests (1980 of them). When I run exactly the same command…

[圖片] Plugin RSpec "get" problems Development You’ll need to run the plugin specs with LOAD_PLUGINS=1 rspec plugins/babble/spec or rake plugin:spec["babble"]

RSpec tests are working fine, it’s the QUnit ones that aren’t working. I’ve tried putting LOAD_PLUGINS=1 before the rake command, but no luck :frowning: I don’t think it’s a typo, since it’s an issue on Discourse’s own travis builds.

It sounds like something that we might have disabled due to random test failures which are unfortunately more common on travis than I’d like. If we can figure out how to run them again I’d be happy to reintroduce them!

That makes sense, but I can’t see any logic that disables/enables them… running rake qunit:test on my mac runs the plugin tests, running it in docker doesn’t…

I’ve been doing a lot of experimenting with QUnit today, and have had another look at this issue. discourse_dev The issue was indeed with the LOAD_PLUGINS environment variable. When using the bin/docker/rake script, the LOAD_PLUGINS variable doesn’t get passed through to the container, hence why I …

[圖片] david: Maybe that’s something that could be used internally to make sure core plugins get tested properly? Or alternatively the LOAD_PLUGINS variable could be set in the Dockerfile? @sam (I think discourse_test is your creation?), what do you think about loading plugins for the tests-pas…

I will have a look at this today… honestly I do not think the community can help out too much here, we have to plug this stuff in to our CI pipeline (we don’t really trust travis cause it is flaky and slow)… having a look at it later today.

Plugin QUnit tests are not running as part of rake qunit:test

Development

Falco (Falco) 2017年三月20日 21:27 2

話題		回覆	觀看
QUnit tests won't pass in discourse_dev docker image Development	19	2750	2017年七月25日
Developing Discourse Plugins - Part 6 - Add acceptance tests Developer Guides testing , plugin-guides , tutorial	32	17861	2022年六月2日
How to run Discourse core, plugin and theme QUnit test suites Developer Guides how-to , code	0	2880	2017年七月26日
Qunit in Docker Development	6	1693	2020年五月14日
Plugins and Continuous Integration Testing Development	0	1008	2016年九月6日

Plugin QUnit tests are not running as part of rake qunit:test

相關主題