# Post view accessibility for last edit link

**URL:** https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539
**Category:** Bug
**Created:** [May 1, 2018, 4:58pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539 "2018-05-01T16:58:45Z")
**Posts on this page:** 11
**Page:** 1

<div class="post-metadata">

### Author: ![sarahann](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sarahann/32/96703_2.png) [@sarahann](https://meta.discourse.org/u/sarahann)
#### Post date: [May 1, 2018, 4:58pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/1 "2018-05-01T16:58:45Z")

</div>

**Problem** : The last edits link is missed because it doesn’t have an href

**Repro Steps:**

1. Navigate to any post view within the forum where the user has edited their response (ie. [Set topic title with Discourse Embed](https://meta.discourse.org/t/set-topic-title-with-discourse-embed/86492) )

2. Press TAB to cycle through the page until you reach the user’s name is highlighted

- notice the topic header is highlighted, the type of issue, the user’s profile image, the user’s name

1. Press TAB again and the focus jumps to the relative date of the post

**Expected behavior** : The focus should have gone from the user’s name, to the last edits link, to the relative date.

I am not sure if this qualifies as a bug, because I am not sure how focused you guys are with accessibility.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [May 1, 2018, 11:24pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/2 "2018-05-01T23:24:08Z")

</div>

Is it that the sequence is out of order, or that it is impossible to tab to the edit indicator?

Perhaps you can take a look @techAPJ

---

<div class="post-metadata">

### Author: ![sarahann](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sarahann/32/96703_2.png) [@sarahann](https://meta.discourse.org/u/sarahann)
#### Post date: [May 1, 2018, 11:34pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/3 "2018-05-01T23:34:22Z")

</div>

It is impossible to tab to it because there is no tabindex or href (which are things that make the links tabbable)

I do have to say, the accessibility for Discourse is really well done. When I opened chromevox to test the post view the descriptions and order of links is really good!

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [November 6, 2018, 1:18am UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/4 "2018-11-06T01:18:43Z")

</div>

Did you have time to look at this @techAPJ? If not perhaps you could give it to someone else to handle? I can confirm tab never reaches that element, which is not good.

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [November 6, 2018, 2:56am UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/6 "2018-11-06T02:56:22Z")

</div>

This got buried in my to-do list, apologies. @nbianca can you take this?

---

<div class="post-metadata">

### Author: ![Matt\_Campbell](https://avatars.discourse-cdn.com/v4/letter/m/73ab20/32.png) [@Matt\_Campbell](https://meta.discourse.org/u/Matt_Campbell)
#### Post date: [November 6, 2018, 2:54pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/7 "2018-11-06T14:54:32Z")

</div>

I’ll take this if no one else has.

---

<div class="post-metadata">

### Author: ![nbianca](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/nbianca/32/157984_2.png) [@nbianca](https://meta.discourse.org/u/nbianca)
#### Post date: [November 6, 2018, 4:30pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/8 "2018-11-06T16:30:30Z")

</div>

@techAPJ I can take this one. 🙂

---

<div class="post-metadata">

### Author: ![Matt\_Campbell](https://avatars.discourse-cdn.com/v4/letter/m/73ab20/32.png) [@Matt\_Campbell](https://meta.discourse.org/u/Matt_Campbell)
#### Post date: [November 6, 2018, 4:46pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/9 "2018-11-06T16:46:04Z")

</div>

I already have a working fix in a private topic branch, just need to submit a PR. Feel free to reject it if a core team member gets there first.

---

<div class="post-metadata">

### Author: ![Matt\_Campbell](https://avatars.discourse-cdn.com/v4/letter/m/73ab20/32.png) [@Matt\_Campbell](https://meta.discourse.org/u/Matt_Campbell)
#### Post date: [November 6, 2018, 4:52pm UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/10 "2018-11-06T16:52:57Z")

</div>

Here’s the [pull request](https://github.com/discourse/discourse/pull/6570).

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [November 7, 2018, 2:12am UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/11 "2018-11-07T02:12:04Z")

</div>

Thanks for quick PR Matt! Sam merged the fix and I verified that the edit link is accessible via tab now.

---

<div class="post-metadata">

### Author: ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)
#### Post date: [November 7, 2018, 2:12am UTC](https://meta.discourse.org/t/post-view-accessibility-for-last-edit-link/86539/12 "2018-11-07T02:12:11Z")

</div>


