# Posts from RSS bumped on each run

**URL:** https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766
**Category:** Bug
**Created:** [27 augustus 2018 om 18:41 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766 "2018-08-27T18:41:04Z")
**Posts on this page:** 11
**Page:** 1

<div class="post-metadata">

### Author: ![darix](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/darix/32/114280_2.png) [@darix](https://meta.discourse.org/u/darix)
#### Post date: [27 augustus 2018 om 18:41 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/1 "2018-08-27T18:41:04Z")

</div>

We upgraded our instance from 2.1.0.beta5 to 2.1.0.beta5~git84.b12cf08c57 today to get the XSS fix.

And it seems since that upgrade it bumps all RSS posts without replies on each and every run of the job.

As you can see here [PIXLS.US - discuss.pixls.us](https://discuss.pixls.us/c/pixls-us)

The obvious candidates from the [git log](https://github.com/discourse/discourse/compare/v2.1.0.beta5...b12cf08c57) between the 2 commits are [932195d828aeb41e24a1eba64e73b55565776b10](https://github.com/discourse/discourse/commit/932195d828aeb41e24a1eba64e73b55565776b10) or [baf413d527d1e1fc7f8e04f357d2f58f14220a8e](https://github.com/discourse/discourse/commit/baf413d527d1e1fc7f8e04f357d2f58f14220a8e) by @tgxworld or @xrav3nz respectively

Or am I missing another change that could explain this behavior?

---

<div class="post-metadata">

### Author: ![xrav3nz](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/xrav3nz/32/76894_2.png) [@xrav3nz](https://meta.discourse.org/u/xrav3nz)
#### Post date: [28 augustus 2018 om 00:39 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/2 "2018-08-28T00:39:12Z")

</div>

Taking a look right now. The posts seem to be bumped by edits but diffs are empty for some reasons…

---

<div class="post-metadata">

### Author: ![darix](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/darix/32/114280_2.png) [@darix](https://meta.discourse.org/u/darix)
#### Post date: [28 augustus 2018 om 01:26 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/3 "2018-08-28T01:26:17Z")

</div>

yeah it only seems to affect posts with no replies. posts with replies  
seems to be fine.

---

<div class="post-metadata">

### Author: ![xrav3nz](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/xrav3nz/32/76894_2.png) [@xrav3nz](https://meta.discourse.org/u/xrav3nz)
#### Post date: [28 augustus 2018 om 02:02 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/4 "2018-08-28T02:02:06Z")

</div>

> [@darix](#):
>
> only seems to affect posts with no replies

Yes, this is because edits to the first post will only bump topics without any replies.

* * *

After making sure this didn’t happen on my private instance, nor did the [a new spec](https://github.com/xrav3nz/discourse/blob/1c469bef12fe94ddbd835e2f07533e5b601c6c03/spec/models/topic_embed_spec.rb#L44-L48) fail:

I took a look into the RSS feed `https://pixls.us/blog/feed.xml`, and found all of the titles have an additional space at the beginning and the end.

```xml
<title>
  <![CDATA[LGM and Libre Graphics at SCaLE 16x]]>
           ^ ^
      the space here and here
</title>

```

This tricks the code into thinking the title have been changed, and tries to update the post. However, the extra spaces in titles are [stripped when saving](https://github.com/discourse/discourse/blob/18266262729598c55310a22f6993797525e2a817/lib/text_cleaner.rb#L49-L50), resulting in an “empty” edit. The loop continues …

* * *

I think we can either

1. drop support for title updates through RSS feeds
2. patch `TopicEmbed` or `PostRevisor` to omit such edits

I’m leaning towards 1, because it is niche enough and we never had this feature before anyway, and 2 requires a lot of careful changes.

* * *

Could you @darix try to drop the spaces in the feed, or “suppress the category from Latest” in the meantime?

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [28 augustus 2018 om 02:09 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/5 "2018-08-28T02:09:10Z")

</div>

I also vote for (1) it is one less risky feature to support.

---

<div class="post-metadata">

### Author: ![xrav3nz](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/xrav3nz/32/76894_2.png) [@xrav3nz](https://meta.discourse.org/u/xrav3nz)
#### Post date: [28 augustus 2018 om 11:22 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/6 "2018-08-28T11:22:02Z")

</div>

Forgot to link back here.

[https://github.com/discourse/discourse/pull/6324](https://github.com/discourse/discourse/pull/6324)

The PR’s been merged, and already in `test-passed`! Let me know if you still experience the problem after updating.

---

<div class="post-metadata">

### Author: ![darix](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/darix/32/114280_2.png) [@darix](https://meta.discourse.org/u/darix)
#### Post date: [28 augustus 2018 om 12:21 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/7 "2018-08-28T12:21:55Z")

</div>

Updated to v2.1.0.beta5+92 - and we are monitoring the issue.

---

<div class="post-metadata">

### Author: ![darix](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/darix/32/114280_2.png) [@darix](https://meta.discourse.org/u/darix)
#### Post date: [28 augustus 2018 om 12:47 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/8 "2018-08-28T12:47:52Z")

</div>

So far it looks good. no bumps since the update.

---

<div class="post-metadata">

### Author: ![darix](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/darix/32/114280_2.png) [@darix](https://meta.discourse.org/u/darix)
#### Post date: [28 augustus 2018 om 14:36 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/9 "2018-08-28T14:36:38Z")

</div>

Just in case you wonder … the bump we see now … is caused by @Patrick_David not just fixing extra whitespaces in the title but also in the actual content of the RSS feed 🙂

---

<div class="post-metadata">

### Author: ![Patrick\_David](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/patrick_david/32/119657_2.png) [@Patrick\_David](https://meta.discourse.org/u/Patrick_David)
#### Post date: [28 augustus 2018 om 14:49 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/10 "2018-08-28T14:49:48Z")

</div>

I never claimed to be a smart man, and assuming this can lead to precarious situations.

Nevertheless, I fixed the odd whitespace in `feed.xml` while I was there. Sorry for screwing up the test case! 😃

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [30 augustus 2018 om 01:00 UTC](https://meta.discourse.org/t/posts-from-rss-bumped-on-each-run/95766/11 "2018-08-30T01:00:17Z")

</div>

This topic was automatically closed after 37 hours. New replies are no longer allowed.
