Prefs page: first- and second-person inconsistencies


(Bill Ayakatubby) #1

(Nit-pick alert) On the preferences page, most of the input labels/values are in the first-person, while the instructions are in the second-person. Some of the input labels don’t have a person at all (favicon, new tab), which I think is fine. But two of the email labels are in the second-person, and it drives me a little nuts:

For clarity, I’m referring to the two email preferences that begin with, “Receive an email…”

Receive an email when someone sends you a private message

Receive an email when someone quotes you, replies to your post, or mentions your @username

I propose the labels be changed to the following:

Send me an email when I receive a private message

Send me an email when someone quotes me, replies to one of my posts, or mentions my @username


(ComputerDruid) #2

I think you mean “second-person” instead of “third-person” here, but I agree that it looks odd.

Edit: I see you’ve updated your post


(Kane York) #3

PR sent for second person, because that’s what the majority are now:

https://github.com/discourse/discourse/pull/2075


(Jeff Atwood) #4