# Probably a bug relative to the close button on banner topic

**URL:** https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532
**Category:** Bug
**Created:** [2017年四月24日 23:28 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532 "2017-04-24T23:28:54Z")
**Posts on this page:** 7
**Page:** 1

<div class="post-metadata">

### Author: ![dax](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dax/32/244677_2.png) [@dax](https://meta.discourse.org/u/dax)
#### Post date: [2017年四月24日 23:28 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532/1 "2017-04-24T23:28:54Z")

</div>

Continuing the discussion from [The close button was displayed on the left side, how to return it to the right?](https://meta.discourse.org/t/the-close-button-was-displayed-on-the-left-side-how-to-return-it-to-the-right/60364):

I have upgraded my test site (only plugins and no site customization) 3 or 4 days ago and I see that I have the close button (for login, sign up and banner) on the left.

I’ve seen it on many forums:

- [http://foodtalkcentral.com/](http://foodtalkcentral.com/) (Discourse 1.8.0.beta10 - [GitHub - discourse/discourse: A platform for community discussion. Free, open, simple. · GitHub](https://github.com/discourse/discourse) version dad20240946ac2af90847c4518268b89b4cf02c8)
- [https://forum.fractalfuture.net/](https://forum.fractalfuture.net/) (Discourse 1.8.0.beta10 - [GitHub - discourse/discourse: A platform for community discussion. Free, open, simple. · GitHub](https://github.com/discourse/discourse) version c9c7ec799f83bc25b1a4f4f1a2beee436b5207c4)
- [https://discuss.moe/](https://discuss.moe/) (Discourse 1.8.0.beta10 - [GitHub - discourse/discourse: A platform for community discussion. Free, open, simple. · GitHub](https://github.com/discourse/discourse) version 4e1f8ec72b791006fca7c6c3347c8347d27e4dc6)
- [https://forums.grimreapergamers.com/](https://forums.grimreapergamers.com/) (Discourse 1.8.0.beta10 - [GitHub - discourse/discourse: A platform for community discussion. Free, open, simple. · GitHub](https://github.com/discourse/discourse) version 82dfe4c5d5867a091f1aa9fef0d04982152d21af)
- [https://community.p2pu.org/](https://community.p2pu.org/) (Discourse 1.8.0.beta9 - [GitHub - discourse/discourse: A platform for community discussion. Free, open, simple. · GitHub](https://github.com/discourse/discourse) version e49f3a408e87d60ddbd1e400f31231bcd147728f)

The difference that I can see with my live site (Discourse 1.8.0.beta10 - [GitHub - discourse/discourse: A platform for community discussion. Free, open, simple. · GitHub](https://github.com/discourse/discourse) version f968b4e6629c352e9f5425e35f5dcbe72f4fbe88) - where the close button is display in the correct position - is relative to the class `.modal-close` (the parent of `.close` I think) where is the ` float:right` statement.

This is my forum:

 ![](https://global.discourse-cdn.com/meta/original/3X/e/7/e7143c9f517b3bcb62846ec99cd8186d8751ca9e.png)

This is [https://discuss.moe/](https://discuss.moe/)  
[Imgur: The magic of the Internet](https://i.imgur.com/pCCRLMb.png)

For example, looking to [http://foodtalkcentral.com/](http://foodtalkcentral.com/) and [https://forum.fractalfuture.net/](https://forum.fractalfuture.net/) I can see the correct position (on the right) when I try to login or signup. There is the class `.modal-close` and the `float: right`, but the close button for banners is on the left.

🙄 🤔

---

<div class="post-metadata">

### Author: ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [2017年四月24日 23:40 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532/2 "2017-04-24T23:40:08Z")

</div>

I think others that also reported this tied it back to a specific plugin. What plugins do you have installed/enabled?

Doesn’t happen on my sandbox or [try.discourse.org](http://try.discourse.org) which are both on latest.

Might be related to [Guest Gate (Sign Up Popup Plugin) - #12 by Shrike](https://meta.discourse.org/t/guest-gate-sign-up-popup-plugin/56625/12)

---

<div class="post-metadata">

### Author: ![dax](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dax/32/244677_2.png) [@dax](https://meta.discourse.org/u/dax)
#### Post date: [2017年四月24日 23:56 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532/3 "2017-04-24T23:56:55Z")

</div>

![](https://global.discourse-cdn.com/meta/original/4X/e/7/4/e74c060b9992fb0ca89d94834b9f3fe63f591faf.png)  
Those are all the plugins in the live site where the button is in the correct position.

In the site test I have all those plugins (but some are disabled as patreon and probably some other)  
The only plugin enabled (by another admin to test it) that I don’t use in my live forum is relative to Steam login.  
The server we use for the test site is off now, so I can try to disable it tomorrow morning. BTW this Steam plugin was enabled for some weeks without problems.  
The only difference is that I asked to my sys-team to upgrade the site test and delete the old backup relative to my live forum because I need to work on it with the plugins and without all the other data (discussions, users, site customization etc…)

**EDIT :** I opened [https://discuss.moe/?safe\_mode=no\_custom%2Cno\_plugins%2Conly\_official](https://discuss.moe/?safe_mode=no_custom%2Cno_plugins%2Conly_official) and [Fractal Future Forum – Envisioning and creating a better future](https://forum.fractalfuture.net/?safe_mode=no_custom%2Cno_plugins%2Conly_official) in `safe-mode` but the close button is still on the left.

> [@cpradio](#):
>
> Might be related to [Guest Gate (Sign Up Popup Plugin) - #12 by Shrike](https://meta.discourse.org/t/guest-gate-sign-up-popup-plugin/56625/12)

I don’t use this plugin

---

<div class="post-metadata">

### Author: ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [2017年四月25日 00:27 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532/4 "2017-04-25T00:27:20Z")

</div>

Oh, I see. I’ve updated your topic title. I completely missed the **banner topic** , as the second screenshot for [https://discuss.moe/](https://discuss.moe/) is showing their login-modal as part of the guest gate plugin (and yes, their site is using guest-gate). That isn’t the topic banner.

I can 100% reproduce this using a topic banner and only in that spot when on latest.

Steps to Reproduce:

1. Navigate to any topic
2. Make it a banner topic
3. Close button is on the top left of the banner (even after a hard refresh)

---

<div class="post-metadata">

### Author: ![dax](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dax/32/244677_2.png) [@dax](https://meta.discourse.org/u/dax)
#### Post date: [2017年四月25日 00:36 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532/5 "2017-04-25T00:36:37Z")

</div>

> [@cpradio](#):
>
> That isn’t the topic banner.

The screens are relative to the login pop-up indeed, because is the only difference that I see.  
So my live site is affected by this bug but I cannot see it because the banner is always the same topic that I edit from time to time.  
Thanks @cpradio

---

<div class="post-metadata">

### Author: ![cpradio](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/cpradio/32/4970_2.png) [@cpradio](https://meta.discourse.org/u/cpradio)
#### Post date: [2017年四月25日 00:58 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532/6 "2017-04-25T00:58:36Z")

</div>

PR  
[https://github.com/discourse/discourse/pull/4832](https://github.com/discourse/discourse/pull/4832)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [2017年四月25日 01:29 UTC](https://meta.discourse.org/t/probably-a-bug-relative-to-the-close-button-on-banner-topic/61532/7 "2017-04-25T01:29:51Z")

</div>


