What is the cancel button expected to do?
I expected that I can either confirm or cancel the changes. However, cancel seems to just close the dialog and I still have to use revert to get back to my original text.
AI-generated summary
The cancel button in the “View Changes” modal dialog only closes the modal, but does not revert changes. Moin expected it to work similarly to the “Confirm” and “Revert” options in the menu, and suggested renaming it to “Close” for clarity. Canapin agreed that “Close” would be a more accurate description. Moin proposed an alternative solution, where the cancel button could be replaced with a “Revert” button, making the modal consistent with the menu. keegan has since updated the feature to include “Confirm” and “Revert” buttons directly inside the modal.
1 Like
Is the modal from the “View Changes” action?
Then, it just closes the modal. In this context, “Close” would be more appropriate.
2 Likes
Yes
That would describe better what it does.
I think I expected it to revert the changes because the menu
offers confirm and revert. The view changes option also allows to confirm so I expected those buttons to work similar. So the other one had to be revert.
Is there an advantage of having only the option to confirm and close?
Maybe it would also be possible to make the cancel button work like the revert button and change the text to revert. Then both dialogs would contain confirm and revert.
Otherwise the changes view could also only have a close button and you could only confirm or revert from the other modal
2 Likes
Thanks @Moin,
I’ve updated it to include the Confirm Revert buttons directly inside the modal.
2 Likes
This topic was automatically closed after 16 hours. New replies are no longer allowed.