Protected topics are showing up in "First Link" badge list


(Michael Downey) #1

See: First Link badge on OpenMRS Talk

Click on “Differences between Community Participant…” topic (or a few others on that list, not all) which are in a group-protected subcategory under an open parent category.


(Sam Saffron) #2

Will put a quick fix in for this now … will have to wait for a badge grant though or trigger it


(Sam Saffron) #3

I just committed this:

https://github.com/discourse/discourse/commit/724fff22e751dc641525ce859307eff3c04c2760

Which will fix this, however there are some additional edge cases I need to fix so leaving this open for now.

(Badge was granted for a regular category and later on the category became secure, so you would have to wait for badge grant)

The bigger fix is checking security in the badge show page, but will have to wait till monday.

Additionally the category UI needs to communicate that badges can not be assigned for secure categories any more.


(Michael Downey) #4

That worked and looks good. Thanks!


(Sam Saffron) #5