# PRs and granularity

**URL:** <https://meta.discourse.org/t/prs-and-granularity/49162>\
**Category:** Development\
**Created:** [24. August 2016 um 19:02 UTC](https://meta.discourse.org/t/prs-and-granularity/49162 "2016-08-24T19:02:31Z")\
**Posts on this page:** 1\
**Showing post:** 2

<div class="post-metadata">

**Author:** ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)\
**Post date:** [24. August 2016 um 20:00 UTC](https://meta.discourse.org/t/prs-and-granularity/49162/2 "2016-08-24T20:00:59Z")

</div>

In this case all the commits are against one file, so I’d suggest squashing them all into one commit and making a PR with bullet points that explains what changed. It needn’t go through every line but the general gist would be a good thing for historical purposes.

Also since it’s an importer and those are largely untested it’s a lot safer - if you break it the next person who does an import will notice but it’s not going to break any discourse sites in production.

---

_[View the full topic](https://meta.discourse.org/t/prs-and-granularity/49162)._