# "q" keyboard shortcut not working

**URL:** https://meta.discourse.org/t/q-keyboard-shortcut-not-working/35901
**Category:** Bug
**Tags:** keyboard, keyboard-shortcuts
**Created:** [November 22, 2015, 11:02am UTC](https://meta.discourse.org/t/q-keyboard-shortcut-not-working/35901 "2015-11-22T11:02:41Z")
**Posts on this page:** 4
**Page:** 1

<div class="post-metadata">

### Author: ![TechnoBear](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/technobear/32/40546_2.png) [@TechnoBear](https://meta.discourse.org/u/TechnoBear)
#### Post date: [November 22, 2015, 11:02am UTC](https://meta.discourse.org/t/q-keyboard-shortcut-not-working/35901/1 "2015-11-22T11:02:41Z")

</div>

Continuing the discussion from [Various keyboard shortcuts no longer working](https://meta.discourse.org/t/various-keyboard-shortcuts-no-longer-working/32679/6):

> [@Various keyboard shortcuts no longer working](https://meta.discourse.org/t/various-keyboard-shortcuts-no-longer-working/32679/6):
>
> Done 😄
> 
> [FIX: 'q' keyboard shortcut not working. by tgxworld · Pull Request #3870 · discourse/discourse · GitHub](https://github.com/discourse/discourse/pull/3870)

It seems to have become unfixed…

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [November 22, 2015, 3:25pm UTC](https://meta.discourse.org/t/q-keyboard-shortcut-not-working/35901/2 "2015-11-22T15:25:24Z")

</div>

Ah this is why it stopped working 😛

[https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/keyboard-shortcuts.js.es6#L103](https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/keyboard-shortcuts.js.es6#L103)

The CSS class is still not updated and is using the old composer’s class.  
 Can’t submit a PR now because I’m away from my dev pc

Anyway, I think we should keep the IDs of the composer’s button as constants and export them to be used in the keyboard shortcuts. This will allow us to avoid having to change the CSS class in multiple places. Is that ok @eviltrout?

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [November 23, 2015, 7:59am UTC](https://meta.discourse.org/t/q-keyboard-shortcut-not-working/35901/3 "2015-11-23T07:59:47Z")

</div>

PR :allthethings:

[https://github.com/discourse/discourse/pull/3906/files](https://github.com/discourse/discourse/pull/3906/files)

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [November 30, 2015, 12:39pm UTC](https://meta.discourse.org/t/q-keyboard-shortcut-not-working/35901/4 "2015-11-30T12:39:16Z")

</div>


