Quick access to bookmarks and messages on user menu

Really like the new design! With the new bookmarks tab maybe it’s worth having some sort of indicator for the author of the post or some other identifying info? Maybe before it in plain text in a similar way to how names in other notifications/messages look? Would help when you have a bunch of bookmarks from the same topic.

7개의 좋아요

Yea that makes sense! I have pushed an update for this, thanks!

I am actually preparing a PR to fold this into core right now. After it’s included in core, I imagine it shouldn’t be too hard to have another theme component that adds custom links there!

12개의 좋아요

It works just fine (made an update). Very comfortably!
Many thanks to everyone! :+1:

3개의 좋아요

This is now in core as of the update I made this morning, so the theme component must be removed to avoid duplicate tabs and weirdness showing up in the menu. Once removed and browser hard refresh all is well. Nice work - this is a fabulous improvement to discourse.

9개의 좋아요

Thanks @Stranik @tobiaseigen! The PR was only just merged around the time you updated!

https://github.com/discourse/discourse/pull/8073

Thanks for the heads-up! I am going to deprecate the theme component with an update (i.e. wipe it out + some console messages).

I originally thought about keeping it so instances on stable can also try out the feature, but I realized it depends on some other new changes in core, so it essentially only works on tests-passed.

8개의 좋아요

I’m really excited this is finally merged! :heart:

That would be a waste :sob:

That theme component is a fantastic example of how to wire things up correctly in the context of themes.

Since we just released a new beta, you can use that to nullify the component based on Discourse version via the maximum_discourse_version. Check this out Adding metadata and screenshots to a Theme

11개의 좋아요

Wow TIL thanks! Tried this out locally and it is so cool!

https://github.com/xrav3nz/discourse-quick-access/commit/b8dbb2147fa39a16e65d7be0e7e34abf0c7b204a

10개의 좋아요

Wow! This is and looks amazing! Well done.

3개의 좋아요

Amazing work, Kyle! :clap:


I noticed a minor issue here, it looks like the Messages and Assigned tabs are having trouble rendering every row with single / double quotes. I’m seeing this on Firefox, Windows if that helps.

Messages

image

Assigned

image

Bookmarks & Notifications
These two tabs can render quotes just fine :ok_hand:

Any ideas?

7개의 좋아요

Nice catch! I just submitted a PR to fix this in core (another will follow shortly for assignment).

https://github.com/discourse/discourse/pull/8095

Special characters are escaped before being rendered, however, fancy_title is already escaped. Escaping it again would print the HTML entity as-is, e.g. " instead of the desired " .

10개의 좋아요

그룹 받은 편지함도 PM 탭에 있어야 하나요? 계속 그곳에 있을 거라고 기대하게 됩니다.

3개의 좋아요

아니요, 제 예상은 그렇지 않습니다.

정리하자면, 해당 탭에는 나에게만 직접 보내진 메시지가 표시되기를 기대합니다.

3개의 좋아요

아, 맞네. 논리적으로는 그런 구분인 것 같긴 하네… 내 입장에서는 좀 어색한 게, 내 프로필에서 모든 메시지가 봉투 아이콘 아래에 모여 있는 반면, 알림 메뉴에는 안 보인다는 거야. (프로필의 메시지 옆 사이드바에서는 구분해서 보여주기 때문에, 전체적으로 UI가 좀 다른 것 같아.)

7개의 좋아요

12개의 게시물이 새 주제로 분리되었습니다: 사용자 메뉴 탭 레이아웃 개선

할당 빠른 액세스 탭에 새로운 경미한 문제가 있습니다. 텍스트가 평소의 파란색 대신 짙은 검은색으로 표시됩니다:

7개의 좋아요

간단히 확인해 보고 이 문제를 수정하기 위해 PR을 열었습니다:

11개의 좋아요

이미 꽤 오래전에 완료되었어요 :heart_eyes_cat:

1개의 좋아요