ランクトチョイス・ポール：結果の票変更が反映されない

merefield · 2024 年 9 月 2 日午前 6:55

このPRは、バグ報告者のインスタンスでpollプラグインのフォークを通じて既にテストされており、この問題を完全に解決するために提起されたことに注意してください。

github.com/discourse/discourse

FIX: poll ranked choice voter expansion should append additional voters

main ← merefield:ranked_choice_voter_expansion_fix

opened 07:02AM - 20 Aug 24 UTC

merefield

+27 -41

Currently, for Ranked Choice results and voter list expansion, the code is repla…cing the voter list with the newly fetched page of voters instead of appending to the existing voter list. This is resolved in this PR and brings it in line with regular polls. See: https://meta.discourse.org/t/ranked-choice-poll-does-not-reflect-change-of-votes-in-outcome/321227/18?u=merefield I've made the tests more strict to cover this and confirmed test failure with existing code without this fix. NB I'm aware code changes around this functionality have been a little numerous of late, so this time, in the interest of minimising review burden and curtailing the iteration, I made sure the changes in this PR were fully tested in Production on the very poll which identified the issue. We've successfully tested the solution in the Production instance of the bug raiser and they have signed off. (We removed the core plugin in app.yml and cloned a fork of Poll that includes these changes).

トピック		返信	表示
Ranked Choice Poll: First vote causes exception & fails to display on outcome Bug polls	3	80	2024 年 11 月 5 日
Polls should automatically switch to results on page load if user has already voted UX polls	9	1828	2018 年 11 月 19 日
Polls don't show additional results when you click the arrow Bug	4	554	2021 年 7 月 6 日
Expanding topic shows wrong poll result value Support polls	4	359	2024 年 3 月 23 日
Ranked choice polls don't do runoffs correctly Bug polls , fixed	8	144	2024 年 8 月 4 日

ランクトチョイス・ポール：結果の票変更が反映されない

関連トピック