排名选择投票未反映结果中的投票变化

merefield · 2024年九月2日 06:55

请注意，此 PR 已提出，并且应该彻底关闭此问题。它已通过 poll 插件的分支在报告 bug 的实例上进行了测试：

github.com/discourse/discourse

FIX: poll ranked choice voter expansion should append additional voters

main ← merefield:ranked_choice_voter_expansion_fix

opened 07:02AM - 20 Aug 24 UTC

merefield

+27 -41

Currently, for Ranked Choice results and voter list expansion, the code is repla…cing the voter list with the newly fetched page of voters instead of appending to the existing voter list. This is resolved in this PR and brings it in line with regular polls. See: https://meta.discourse.org/t/ranked-choice-poll-does-not-reflect-change-of-votes-in-outcome/321227/18?u=merefield I've made the tests more strict to cover this and confirmed test failure with existing code without this fix. NB I'm aware code changes around this functionality have been a little numerous of late, so this time, in the interest of minimising review burden and curtailing the iteration, I made sure the changes in this PR were fully tested in Production on the very poll which identified the issue. We've successfully tested the solution in the Production instance of the bug raiser and they have signed off. (We removed the core plugin in app.yml and cloned a fork of Poll that includes these changes).

話題		回覆	觀看
Ranked Choice Poll: First vote causes exception & fails to display on outcome Bug polls	2	170	2024年九月18日
Polls should automatically switch to results on page load if user has already voted UX polls	9	1970	2018年十一月19日
Polls don't show additional results when you click the arrow Bug	3	606	2021年七月6日
Large poll bug - users cannot amend votes on open polls Bug	3	200	2026年六月18日
Expanding topic shows wrong poll result value Support polls	2	420	2020年三月23日

排名选择投票未反映结果中的投票变化

相關主題