# Rebuilds fail for anyone with discourse-narrative-bot in app.yml

**URL:** https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410
**Category:** Support
**Created:** [May 26, 2017, 1:53am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410 "2017-05-26T01:53:54Z")
**Posts on this page:** 11
**Page:** 1

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [May 26, 2017, 1:53am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/1 "2017-05-26T01:53:54Z")

</div>

Since discourse-narrative-bot is now a core plugin, and contained within the core repository, there is now no need for the

```plaintext
git clone https://github.com/discourse/discourse-narrative-bot.git

```

line in app.yml.

Anyone who tries to rebuild with that line in their config will get an error message

```plaintext
exec failed with the params {"cd"=>"$home/plugins", "cmd"=>["git clone https://github.com/discourse/docker_manager.git", "git clone https://github.com/discourse/discourse-narrative-bot.git"]}

```

This will affect

- Those who installed discourse-narrative-bot deliberately on their forums
- Anyone who installed discourse fresh between [19th May](https://github.com/discourse/discourse_docker/commit/fcdd39da610f036f36e8f9e70bf0ca93ef95b23a) and [24th May](https://github.com/discourse/discourse_docker/commit/2d8ea72a4b3d8bba4bc9af2dadbb391b52b7259d)

This is a repeat of

> [@Has discourse-details moved into discourse?](https://meta.discourse.org/t/has-discourse-details-moved-into-discourse/37682):
>
> My update to 1.5.0.beta8 today failed (I think it was when I attempted the upgrade from the web interface) because discourse-details, which I had in my plugins, was not empty. It looks like this means that discourse-details moved into discourse proper, so my adding it as a plugin was superfluous and detrimental. The error I got was fatal: destination path 'discourse-details' already exists and is not an empty directory. If you get this, you need to edit app.yml and remove your discourse-detai…

I guess the only solution on the discourse end would be to rename the plugin in core (maybe just to `narrative-bot`, in line with the `polls` and `lazyYT` plugins), and then empty the discourse-narrative-bot repo (but don’t delete it cos that’ll cause errors as well).

Alternatively, everyone should remove discourse-narrative-bot from their app.yml.

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [May 26, 2017, 2:23am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/2 "2017-05-26T02:23:08Z")

</div>

> [@david](#):
>
> Alternatively, everyone should remove discourse-narrative-bot from their app.yml.

I’ll prefer this approach. Otherwise, people would leave lines that are no longer used in their config file forever.

---

<div class="post-metadata">

### Author: ![JagWaugh](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jagwaugh/32/69335_2.png) [@JagWaugh](https://meta.discourse.org/u/JagWaugh)
#### Post date: [May 26, 2017, 11:00am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/4 "2017-05-26T11:00:52Z")

</div>

I agree about removing vestigial entries.

On the other hand, now that it is in core, why is the config still presented as a plugin? Is this an artefact of my having had it included in my config while it was still a “proper” plugin?

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [May 26, 2017, 2:14pm UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/5 "2017-05-26T14:14:58Z")

</div>

> [@david](#):
>
> Anyone who installed discourse fresh between 19th May and 24th May

I think we can live with supporting this, its a pretty small window.

---

<div class="post-metadata">

### Author: ![tophee](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tophee/32/73406_2.png) [@tophee](https://meta.discourse.org/u/tophee)
#### Post date: [May 26, 2017, 8:35pm UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/6 "2017-05-26T20:35:27Z")

</div>

Aha! When I checked `/admin/upgrade` today and saw that the latest change in the bot plugin was that it has been deleted and moved to core I did not dare to upgrade. Looks like my fears were not totally unwarranted. (Though I’m not sure what you mean by

> [@david](#):
>
> Those who installed discourse-narrative-bot deliberately on their forums

Can you install a plugin non-deliberately?)

Could someone explain what people who have the bot installed need to watch out for? More precisely: in what order to I do things when removing the bot from `app.yml`? Or do I just remove it and that’s it?

---

<div class="post-metadata">

### Author: ![david](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/david/32/157490_2.png) [@david](https://meta.discourse.org/u/david)
#### Post date: [May 26, 2017, 8:40pm UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/7 "2017-05-26T20:40:51Z")

</div>

> [@tophee](#):
>
> Can you install a plugin non-deliberately

Well I guess that’s what just happened to everyone who updated core, the narrative bot plugin is being installed auto-magically 😉

> [@tophee](#):
>
> Or do I just remove it and that’s it?

Yep, as far as I know you just remove it from app.yml, rebuild, and all will be well. That worked for my install with no problems.

---

<div class="post-metadata">

### Author: ![pfaffman](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pfaffman/32/120154_2.png) [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [May 26, 2017, 11:01pm UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/8 "2017-05-26T23:01:22Z")

</div>

> [@sam](#):
>
> I think we can live with supporting this, its a pretty small window.

It’s pretty small set of people who did a new install and got a plugin installed unbeknownst to them. If it’s easy to make the plugin just disable itself rather than make the build fail, that seems preferable.

I understand correctly, it also means that people who installed the plugin will have their rebuilds fail. I’m less worried about them, though, as if they installed the plugin, they presumably also know how to uninstall it. Even for them, though, some deprecation warning seems more gentle.

---

<div class="post-metadata">

### Author: ![JagWaugh](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jagwaugh/32/69335_2.png) [@JagWaugh](https://meta.discourse.org/u/JagWaugh)
#### Post date: [May 27, 2017, 4:01am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/9 "2017-05-27T04:01:13Z")

</div>

> [@tophee](#):
>
> More precisely: in what order to I do things when removing the bot from app.yml? Or do I just remove it and that’s it?

I just edited app.yml and removed the narrative-bot line then did a ./launcher rebuild app.

That was _after_ I did a rebuild with the line still in (I wanted to add a different plugin in), and watched the rebuild barf all over itself. Then I raised both eyebrows, then I removed discobot manually and rebuilt.

---

<div class="post-metadata">

### Author: ![tophee](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tophee/32/73406_2.png) [@tophee](https://meta.discourse.org/u/tophee)
#### Post date: [May 27, 2017, 9:09am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/10 "2017-05-27T09:09:56Z")

</div>

> [@david](#):
>
> Or do I just remove it and that’s it?
> 
> Yep, as far as I know you just remove it from app.yml, rebuild, and all will be well. That worked for my install with no problems.

I can confirm that this worked for me too.

---

<div class="post-metadata">

### Author: ![system](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/system/32/443519_2.png) [@system](https://meta.discourse.org/u/system)
#### Post date: [June 25, 2019, 12:58am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/14 "2019-06-25T00:58:43Z")

</div>



---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [June 26, 2019, 9:12am UTC](https://meta.discourse.org/t/rebuilds-fail-for-anyone-with-discourse-narrative-bot-in-app-yml/63410/15 "2019-06-26T09:12:41Z")

</div>


