Red notification always links to flag queue

feature
1

Summary: Posts needing approval uses the same red notification as flags. Clicking on the red notification icon always leads to flag queue even when there are no pending flags.

Steps to reproduce:

  1. Enable post approval in some way.
  2. Have a post in queue with no pending flags
  3. Click on red notification icon (not on hamburger menu).

Expected Results:

Approval queue page opens

Actual Results:

Flag queue opens

Notes:

Not really sure how this should work if both posts and flags are pending - perhaps just prioritize flags, and once no flags remain redirect link to approval queue

Version Number:

Discourse 1.7.0.beta4 (discourse.stonehearth.net)

System Information:

Windows 10 Education, Chrome Stable 53

7 Likes
2

I’d been clicking on the hamburger menu (larger target) & clicking approvals for so long that I forgot this was an issue.

1 Like
3

We should fix this @neil.

2 Likes
4

@codinghorror, what are your thoughts on how to handle this when there are both flags and posts needing approval? Does one take priority, does it open the hamburger menu, something else?

Edit: this may also affect Akismet - unsure…

5

We should just remove the direct red circle link, people should expand the menu at all times @neil.

4 Likes
6

How about making the hamburger turn red, to draw attention to it?

1 Like
7

I am only proposing removing the link not the red circle and number.

10

Can you take a look at this next week @eviltrout? Might be a nice small tweak.

11

It looks like @neil changed this 4 months ago:

https://github.com/discourse/discourse/commit/ff508ed75ffec97dd5239787c7ed3340568142f4

5 Likes