Hi! Somewhere while upgrading from 2.4.0.beta1 to 2.4.0.beta2 to 2.4.0.beta4 (not sure on which upgrade exactly) the registration modal stopped showing up for new users. We use the OpenID Connect plugin to authenticate our users. Login is required, local logins are disabled and new registrations a…

I was able to fix those particular error messages in this commit. Not sure if it fixes the modal issue, but it seems related. https://github.com/discourse/discourse-knowledge-base-theme/commit/04ff864caf6823d37cb3cb1c153e0b7ed392fd3d

Fantastic, you were right! Removing the Knowledge Base component from the theme made the modal appear again! I obviously installed the component between one of those upgrades. Strange enough, this is only true after I restore the backup, a clean install shows no such issue with the component enable…

That’s really peculiar. Do you recall seeing any particular errors with that component, such as in the browser developer console?

Indeed, under https://<HOST>/logs, I read the following: Uncaught TypeError: Cannot read property 'knowledge-base' of undefined [Screenshot_2019-10-14%20Logs] Additionally, there’s 8 times a TypeError: E.idMap(...) is undefined, but with no mentioning of the Knowledge Base component. It has the f…

[תמונה] fkohrt: I will just disable it, we weren’t using it anyways. I have some thoughts on what might be causing it. I’m curious, though – did you have any categories listed in the kb categories theme setting while it was enabled? I can see a case in the code where it may cause an issue if…

[תמונה] justin: did you have any categories listed in the kb categories theme setting while it was enabled? Indeed, I had no categories listed. But the modal does not display even after choosing one. Maybe related, but maybe something totally different: The default to kb view setting has no …

Are you seeing those same errors in logs? What’s happening here is there’s a route getting triggered that’s trying to look for the knowledge base component before it’s loaded.

[תמונה] justin: Are you seeing those same errors in logs? Yeah, but they don’t stack anymore, but differ in the fourth line of their backtrace. The other lines look as above. initialize/</<@https://<HOST>/theme-javascripts/<VARIES>.js?__ws=<HOST>:103:48 [Screenshot_2019-10-14%20Logs]

I added another commit with some additional checks to stop trying to query uninitialized items. https://github.com/discourse/discourse-knowledge-base-theme/commit/e0d7813e9f4b9c6031de6eb5a062ed4434a83069

No difference, TypeErrors keep coming up.

Registration modal/popup not showing up for private instance

תמיכה

david (David Taylor) 14 באוקטובר,‏ 2019,‏ 2:27pm 2

Do you have any theme components installed on the site? Does the issue persist in safe mode?

נושא		תגובות	צפיות
Custom theme modals no longer open Development	1	789	4 באוגוסט,‏ 2022
Edit Category Button and New Category Button not working Support	12	1851	8 במאי,‏ 2015
Sign up modal does not render when local logins are disabled Bug	4	567	6 באפריל,‏ 2021
SSO & Registration Popup Problems? Support	17	2230	25 בספטמבר,‏ 2017
Install theme button not working on Meta Site feedback	4	577	6 בדצמבר,‏ 2023

Registration modal/popup not showing up for private instance

נושאים קשורים