Hi! Somewhere while upgrading from 2.4.0.beta1 to 2.4.0.beta2 to 2.4.0.beta4 (not sure on which upgrade exactly) the registration modal stopped showing up for new users. We use the OpenID Connect plugin to authenticate our users. Login is required, local logins are disabled and new registrations are allowed. Disabling the login requirement or enabling local logins “resolves” the issue and users may register again. Local logins should, however, stay disabled and we want logins to be required as well. The OIDC Log is normal and shows a Fetched userinfo response with the new user’s credentials although no modal shows up. I tried moving to a fresh install and restoring the backup, but the issue persists. Without restoring my backup, the modal shows up, so there’s something with my backup that makes this issue appear :confused: Our current Discourse version is 2.4.0.beta6, where the issue is present as well.

I was able to fix those particular error messages in this commit. Not sure if it fixes the modal issue, but it seems related. https://github.com/discourse/discourse-knowledge-base-theme/commit/04ff864caf6823d37cb3cb1c153e0b7ed392fd3d

Do you have any theme components installed on the site? Does the issue persist in safe mode?

Fantastic, you were right! Removing the Knowledge Base component from the theme made the modal appear again! I obviously installed the component between one of those upgrades. Strange enough, this is only true after I restore the backup, a clean install shows no such issue with the component enabled. I will just disable it, we weren’t using it anyways. Thanks for helping out!

That’s really peculiar. Do you recall seeing any particular errors with that component, such as in the browser developer console?

Indeed, under https:// /logs, I read the following: Uncaught TypeError: Cannot read property 'knowledge-base' of undefined [Screenshot_2019-10-14%20Logs] Additionally, there’s 8 times a TypeError: E.idMap(...) is undefined, but with no mentioning of the Knowledge Base component. It has the following backtrace (Url: https:// /assets/application-301651b1c7400a000974a9cecafd44ad3304cf647cf17bcfa7af68e9ed1ac4b7.js, Line: 9, Column: 20924, Window Location: https:// /login): findById@https:// /assets/application-301651b1c7400a000974a9cecafd44ad3304cf647cf17bcfa7af68e9ed1ac4b7.js:9:20924 findByIds/ /assets/application-301651b1c7400a000974a9cecafd44ad3304cf647cf17bcfa7af68e9ed1ac4b7.js:9:21063 findByIds@https:// /assets/application-301651b1c7400a000974a9cecafd44ad3304cf647cf17bcfa7af68e9ed1ac4b7.js:9:21035 initialize/ /theme-javascripts/ce296772003fb6162b99b62bf564066966940cc8.js?__ws= :103:48 value/ /assets/application-301651b1c7400a000974a9cecafd44ad3304cf647cf17bcfa7af68e9ed1ac4b7.js:14:5447 C@https:// /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:6:19799 trigger@https:// /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:9:20668 s/ /assets/application-301651b1c7400a000974a9cecafd44ad3304cf647cf17bcfa7af68e9ed1ac4b7.js:13:31963 y /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:16:9739 y /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:16:8732 b /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:16:10782 H /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:16:15440 H /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:16:12110 H /assets/ember_jquery-7dfac344d893a6c10c016353b994db2c6f42af630322ea6da3399c220fcc50ed.js:16:16800

[图片] fkohrt: I will just disable it, we weren’t using it anyways. I have some thoughts on what might be causing it. I’m curious, though – did you have any categories listed in the kb categories theme setting while it was enabled? I can see a case in the code where it may cause an issue if there are no categories selected. EDIT: I’ve pushed a fix that I think might handle the issue. https://github.com/discourse/discourse-knowledge-base-theme/commit/c0f1be63a47d809685ae89d411dd8a8f10202fc4

[图片] justin: did you have any categories listed in the kb categories theme setting while it was enabled? Indeed, I had no categories listed. But the modal does not display even after choosing one. Maybe related, but maybe something totally different: The default to kb view setting has no effect while the category is being displayed, and I have to click on the KB button and the Latest button back and forth to enable the KB view. edit: I updated the component and it behaves now as follows: With an empty category listing, the modal does show up :tada:. Once I choose a category, however, the modal does not show up anymore.

Are you seeing those same errors in logs? What’s happening here is there’s a route getting triggered that’s trying to look for the knowledge base component before it’s loaded.

[图片] justin: Are you seeing those same errors in logs? Yeah, but they don’t stack anymore, but differ in the fourth line of their backtrace. The other lines look as above. initialize/ /theme-javascripts/ .js?__ws= :103:48 [Screenshot_2019-10-14%20Logs]

I added another commit with some additional checks to stop trying to query uninitialized items. https://github.com/discourse/discourse-knowledge-base-theme/commit/e0d7813e9f4b9c6031de6eb5a062ed4434a83069

No difference, TypeErrors keep coming up.

注册模态框/弹出窗口未显示在私有实例中

产品支持

david (David Taylor) 2019 年10 月 14 日 14:27 2

您的网站上是否安装了任何主题组件？在安全模式下问题是否仍然存在？

话题		回复	浏览量
Custom theme modals no longer open Development	1	816	2022 年8 月 4 日
Edit Category Button and New Category Button not working Product Support	12	1994	2015 年5 月 8 日
Sign up modal does not render when local logins are disabled Bug	4	590	2021 年4 月 6 日
SSO & Registration Popup Problems? Product Support	17	2489	2017 年9 月 25 日
Install theme button not working on Meta Site feedback	4	633	2023 年12 月 6 日

注册模态框/弹出窗口未显示在私有实例中

相关话题