# Regression causing erroneous, incorrect email notifications sent to all users in the approval queue for over 60 days

**URL:** <https://meta.discourse.org/t/regression-causing-erroneous-incorrect-email-notifications-sent-to-all-users-in-the-approval-queue-for-over-60-days/180782>\
**Category:** Bug\
**Created:** [February 22, 2021, 7:03pm UTC](https://meta.discourse.org/t/regression-causing-erroneous-incorrect-email-notifications-sent-to-all-users-in-the-approval-queue-for-over-60-days/180782 "2021-02-22T19:03:33Z")\
**Posts on this page:** 1\
**Showing post:** 1

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [February 22, 2021, 7:03pm UTC](https://meta.discourse.org/t/regression-causing-erroneous-incorrect-email-notifications-sent-to-all-users-in-the-approval-queue-for-over-60-days/180782/1 "2021-02-22T19:03:34Z")

</div>

In Discourse, you can specify a mode where user accounts are created on signup, but must be approved by a staff member before the account is activated. This is common on subscription based sites, for example.

There were two important aspects of how this worked:

1. No negative notifications were ever sent when staff rejected accounts, only a single positive notification was sent when staff approved accounts.

2. Any item in the review queue, whether it is a post or an account, will be default-denied after 60 days if a moderator does not act on the review queue item in that 60 day period. This has existed in many previous versions of Discourse, as this path was chosen to be “default safe”.

Unfortunately, when we added a [new, requested feature to let users know why they were rejected](https://github.com/discourse/discourse/commit/06b7c44593fe8299d120a8956b57b4a9b484131e), what we did not realize is the combination of #1 and #2, above, **would cause Discourse to send individual negative notifications to _all_ users who existed in the approval queue for more than 60 days!**

Those email notifications looked like this:

 ![image](https://global.discourse-cdn.com/meta/original/3X/9/f/9fffe748165c2b7c2b6840434dcb6a864a81b122.png)

and said, under the customer’s brand,

> A staff member rejected your account on {brand}.

This message being sent to so many “rejected” accounts has caused problems for our hosted customers. We’re deeply sorry about this mistake – it is completely our fault at Discourse, and all the blame should lay with us.

We’re currently working with our customers to do everything we can to make it right.

We’d like to be crystal clear that this is **our bug** and **we sent a very confusing, badly worded email** to a lot of their customers, resulting in considerable disruption, and possibly even loss of revenue as customers cancel their subscriptions. We’re _so sorry_ about this, and the very least we can do is to let everyone know that **it’s a problem with Discourse, we at Discourse incorrectly sent that negative email**. We’re fully responsible for that bug and its consequences. If you received that email, it was through no fault of anyone but us – at Discourse.

We understand how serious this is. We continue to work closely with the membership provider, and our affected customers, to take responsibility for our actions and improve things so this can’t happen again.

We’re also offering the next month of this customer’s hosting free, as compensation for the problems we’ve caused. We sincerely apologize for the error and the way it affected our customers. We will absolutely be revisiting our processes to make sure this type of problem is less likely to occur in the future.

Jeff Atwood  
CEO, Discourse

---

_[View the full topic](https://meta.discourse.org/t/regression-causing-erroneous-incorrect-email-notifications-sent-to-all-users-in-the-approval-queue-for-over-60-days/180782)._
