Regression - PDFs download initiated on click (should be open in new tab)

[nathank (Nathan Kershaw)]

Currently, I’m finding that clicking on the PDF link when a PDF preview is active currently attempts to download the PDF (undesired) instead of opening it in a new tab.

This is with simple self-hosting (single container, no CDN, no S3, horizon theme).

This whole thing was addressed back here:

@david

This should be resolved since SECURITY: Download allowlist for uploaded files · discourse/discourse@9c0642a · GitHub

We now have centralised logic to determine which files should be shown ‘inline’. That means that PDFs are consistently shown inline, and some less safe file types are consistently served as downloads. These changes should work on all types of upload storage (local & S3, with or without CDNs).

The reason why this is a problem is that a common user desire is to read an inline PDF in the entire window, as the iframe is quite restrictive. Download adds an unecessarily annoying step. And there is already a download button in the toolbar of the PDF viewer in the iframe (at least there is in Chrome).

[zogstrip]

We were being inconsistent with the display type depending on whether you were using S3 or not. That should be fixed by

FIX: Serve inline-safe uploads inline on the local file store (#40739)

(cc @david)

The fact that clicking on a file opens automatically in another tab is more a product question.