# Regression: quoting text from a closed topic

**URL:** https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902
**Category:** Bug
**Created:** [February 28, 2020, 5:23pm UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902 "2020-02-28T17:23:03Z")
**Posts on this page:** 13
**Page:** 1

<div class="post-metadata">

### Author: ![supermathie](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/supermathie/32/507518_2.png) [@supermathie](https://meta.discourse.org/u/supermathie)
#### Post date: [February 28, 2020, 5:23pm UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/1 "2020-02-28T17:23:04Z")

</div>

Continuing the discussion from [Quote post from closed topic](https://meta.discourse.org/t/quote-post-from-closed-topic/26480/11):

> [@Quote post from closed topic](https://meta.discourse.org/t/quote-post-from-closed-topic/26480/11):
>
> everywhere on Discourse you can select text and a button to quote will appear. Not on closed topics

I think this _used_ to be fixed but has regressed now:

 ![image](https://global.discourse-cdn.com/meta/original/3X/8/9/89e8034acfe3c9f07561a55b457912ffca766ff1.png)

I encountered this in the wild as a normal user on [elastic](https://discuss.elastic.co/) trying to do normal user things.

(attn: @eviltrout)

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [March 2, 2020, 5:32pm UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/2 "2020-03-02T17:32:12Z")

</div>

@supermathie I asked in chat but I think it got lost: was this the result of you disabling a user preference for highlight quoting?

---

<div class="post-metadata">

### Author: ![supermathie](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/supermathie/32/507518_2.png) [@supermathie](https://meta.discourse.org/u/supermathie)
#### Post date: [March 2, 2020, 5:32pm UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/3 "2020-03-02T17:32:45Z")

</div>

It was not. Quoting was enabled and worked on open topics on both sites.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [March 3, 2020, 2:23am UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/4 "2020-03-03T02:23:26Z")

</div>

Can we repro this @jomaxro? Does feel like a bug and a regression to me?

---

<div class="post-metadata">

### Author: ![jomaxro](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jomaxro/32/126216_2.png) [@jomaxro](https://meta.discourse.org/u/jomaxro)
#### Post date: [March 4, 2020, 1:12pm UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/8 "2020-03-04T13:12:51Z")

</div>

I can repro, yes. Quote button isn’t appearing for non-staff users in closed topics. Old discussion for reference: [Quote post from closed topic](https://meta.discourse.org/t/quote-post-from-closed-topic/26480)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [March 4, 2020, 4:48pm UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/9 "2020-03-04T16:48:42Z")

</div>

Can we get this fixed and backported @eviltrout?

---

<div class="post-metadata">

### Author: ![riking](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/riking/32/170938_2.png) [@riking](https://meta.discourse.org/u/riking)
#### Post date: [March 6, 2020, 12:12am UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/13 "2020-03-06T00:12:34Z")

</div>

Sent in [FIX: Allow quoting from a closed topic while writing a reply by riking · Pull Request #9121 · discourse/discourse · GitHub](https://github.com/discourse/discourse/pull/9121) !

---

<div class="post-metadata">

### Author: ![jomaxro](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jomaxro/32/126216_2.png) [@jomaxro](https://meta.discourse.org/u/jomaxro)
#### Post date: [March 6, 2020, 3:47am UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/14 "2020-03-06T03:47:22Z")

</div>

Noticed another quoting regression. The quote button does not appear within `[quote]` blocks. It does work in quote blocks that include a username, like `[quote=jomaxro]`, as well as in `>` blocks.

**Works:**

```plaintext
[quote=jomaxro]
Lorem Ipsum
[/quote]

```

```plaintext
> Lorem Ipsum

```

**Doesn’t work:**

```plaintext
[quote]
Lorem Ipsum
[/quote]

```

Let me know if you’d rather have this split into a dedicated topic.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [March 6, 2020, 5:51am UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/15 "2020-03-06T05:51:35Z")

</div>

Sorry, what are you reporting here? I am unclear.

---

<div class="post-metadata">

### Author: ![rishabh](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rishabh/32/179446_2.png) [@rishabh](https://meta.discourse.org/u/rishabh)
#### Post date: [March 6, 2020, 5:56am UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/16 "2020-03-06T05:56:30Z")

</div>

I think he meant that the quote button does not pop up if you post `[quote]` blocks manually without a username. Try quoting this:

> [@](#):
>
> Lorem Ipsum

The Quote button does not show up:

![image](https://global.discourse-cdn.com/meta/original/3X/a/a/aabab47492b81c98af71b9f5b7c834a0a1a20d71.png)

* * *

On the other hand, it shows up as expected when username is added. Try quoting this:

> [@jomaxro](#):
>
> Lorem Ipsum

You’ll see that the quote button shows up:

 ![image](https://global.discourse-cdn.com/meta/original/3X/5/6/56d990aa620979c112659aead8a19db32dd54288.png)

* * *

This should only affect users that type in quote blocks manually.

---

<div class="post-metadata">

### Author: ![riking](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/riking/32/170938_2.png) [@riking](https://meta.discourse.org/u/riking)
#### Post date: [March 6, 2020, 7:14am UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/17 "2020-03-06T07:14:34Z")

</div>

This is probably causing a false positive on the nested-quote-quoting-misattribution protection.

---

<div class="post-metadata">

### Author: ![riking](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/riking/32/170938_2.png) [@riking](https://meta.discourse.org/u/riking)
#### Post date: [March 6, 2020, 7:08pm UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/18 "2020-03-06T19:08:25Z")

</div>

Or, it’s just straight-up throwing a Javascript exception 🙂

[https://github.com/discourse/discourse/pull/9132](https://github.com/discourse/discourse/pull/9132)

---

<div class="post-metadata">

### Author: ![riking](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/riking/32/170938_2.png) [@riking](https://meta.discourse.org/u/riking)
#### Post date: [March 8, 2020, 1:41am UTC](https://meta.discourse.org/t/regression-quoting-text-from-a-closed-topic/142902/19 "2020-03-08T01:41:21Z")

</div>


