# Removal of ember-addons/ember-computed-decorators

**URL:** https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977
**Category:** Development
**Created:** [November 9, 2019, 1:22am UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977 "2019-11-09T01:22:29Z")
**Posts on this page:** 13
**Page:** 1

<div class="post-metadata">

### Author: ![angus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/angus/32/341715_2.png) [@angus](https://meta.discourse.org/u/angus)
#### Post date: [November 9, 2019, 1:22am UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/1 "2019-11-09T01:22:29Z")

</div>

@markvanlan The move of the decorators from `ember-addons/ember-computed-decorators` to `discourse-common/utils/decorators` is about to break a number of plugins and themes as soon as folks hit the big blue update button.

[https://github.com/discourse/discourse/pull/8312](https://github.com/discourse/discourse/pull/8312)

Would it be possible to leave the existing decorators in place (in addition to the new ones) to give us time to make the transition?

---

<div class="post-metadata">

### Author: ![markvanlan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/markvanlan/32/160087_2.png) [@markvanlan](https://meta.discourse.org/u/markvanlan)
#### Post date: [November 9, 2019, 1:25am UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/2 "2019-11-09T01:25:51Z")

</div>

This should not be a breaking change. Here in the discourse-loader file, we have added an alias, so that anytime you try and import `ember-addons/ember-computed-decorators`, it will automatically load `discourse-common/utils/decorator` instead.

> <https://github.com/discourse/discourse/blob/15f6f57cdcebc7583ddb5a311174d10a7300ae4a/app/assets/javascripts/discourse-loader.js#L6>

---

<div class="post-metadata">

### Author: ![angus](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/angus/32/341715_2.png) [@angus](https://meta.discourse.org/u/angus)
#### Post date: [November 9, 2019, 1:30am UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/3 "2019-11-09T01:30:20Z")

</div>

Yeah, I saw that. I’m not sure why, but that doesn’t seem to be working in all cases. I’m gettting a lot of requirejs errors that seem to resolve once I move to the new import.

---

<div class="post-metadata">

### Author: ![markvanlan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/markvanlan/32/160087_2.png) [@markvanlan](https://meta.discourse.org/u/markvanlan)
#### Post date: [November 9, 2019, 1:32am UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/5 "2019-11-09T01:32:23Z")

</div>

Are you able to see if it is happening when using `require` instead of `import`?

That was a bug that I thought I had fixed.

---

<div class="post-metadata">

### Author: ![outofthebox](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/outofthebox/32/83708_2.png) [@outofthebox](https://meta.discourse.org/u/outofthebox)
#### Post date: [February 20, 2020, 2:54pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/6 "2020-02-20T14:54:56Z")

</div>

Hi,

Here is the error message I hit on my Discourse site:

![Screen Shot 2020-02-19 at 2.50.56 PM](https://global.discourse-cdn.com/meta/optimized/3X/c/d/cd33571829616bbb676ad3af2e6b16590537049a_2_690x23.png)

Does this still need to be updated in the code base?

---

<div class="post-metadata">

### Author: ![markvanlan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/markvanlan/32/160087_2.png) [@markvanlan](https://meta.discourse.org/u/markvanlan)
#### Post date: [February 20, 2020, 2:59pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/7 "2020-02-20T14:59:38Z")

</div>

I can’t see exactly where that error is coming from (what plugin is using `ember-addons/ember-compted-decorators`), but it does eventually need to be fixed.

That is a warning, rather than an error because `ember-addons/ember-compted-decorators` is still functional for now.

---

<div class="post-metadata">

### Author: ![outofthebox](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/outofthebox/32/83708_2.png) [@outofthebox](https://meta.discourse.org/u/outofthebox)
#### Post date: [February 20, 2020, 3:40pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/8 "2020-02-20T15:40:11Z")

</div>

Thanks @markvanlan,

What method do you use or recommend to identify a plugin that’s using deprecated assets?

---

<div class="post-metadata">

### Author: ![markvanlan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/markvanlan/32/160087_2.png) [@markvanlan](https://meta.discourse.org/u/markvanlan)
#### Post date: [February 20, 2020, 3:43pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/9 "2020-02-20T15:43:31Z")

</div>

I would see what plugins you have installed on your instance, then go to each repository in Github and search for `ember-addons/ember-compted-decorators`.

I believe some of our official Discourse plugins still need this updated so it could be one of our repos.

---

<div class="post-metadata">

### Author: ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)
#### Post date: [February 20, 2020, 3:47pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/10 "2020-02-20T15:47:40Z")

</div>

Can you expand that and see the full backtrace?

---

<div class="post-metadata">

### Author: ![RGJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/rgj/32/523185_2.png) [@RGJ](https://meta.discourse.org/u/RGJ)
#### Post date: [February 20, 2020, 3:52pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/11 "2020-02-20T15:52:06Z")

</div>

I don’t know how to see the backtrace behind a browser console warning?

I do know how to grep plugins though 😄

```
$ grep -r ember-addons/ember-computed-decorators plugins/|grep import|awk -F / '{print $2}'|uniq|sort
discourse-canned-replies
discourse-local-dates
discourse-presence
discourse-push-notifications
discourse-saved-searches
procourse-memberships

```

---

<div class="post-metadata">

### Author: ![outofthebox](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/outofthebox/32/83708_2.png) [@outofthebox](https://meta.discourse.org/u/outofthebox)
#### Post date: [February 20, 2020, 4:06pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/12 "2020-02-20T16:06:02Z")

</div>

Hi, I can’t currently reproduce it. But, the phenomenal @RGJ just updated the plugins on our site and I think this resolved the error? He pointed me to these updates:

> [DEV: Find/replace deprecated decorators · discourse/discourse-data-explorer@277346b · GitHub](https://github.com/discourse/discourse-data-explorer/commit/277346b09709deac714d70c8cbd525f69f0984b4)

---

<div class="post-metadata">

### Author: ![merefield](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/merefield/32/176214_2.png) [@merefield](https://meta.discourse.org/u/merefield)
#### Post date: [February 20, 2020, 4:11pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/13 "2020-02-20T16:11:47Z")

</div>

Nice Grep Richard! 🙂

I don’t think this is a lot to panic about.

It’s the responsibility of plugin makers to minimise these warnings ASAP too.

I’ve resolved quite a few recently and there will be more. It’s a never ending story 😉

They are just warnings and nothing to really worry about unless they are ignored for too long.

---

<div class="post-metadata">

### Author: ![outofthebox](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/outofthebox/32/83708_2.png) [@outofthebox](https://meta.discourse.org/u/outofthebox)
#### Post date: [February 20, 2020, 4:30pm UTC](https://meta.discourse.org/t/removal-of-ember-addons-ember-computed-decorators/132977/14 "2020-02-20T16:30:23Z")

</div>

Thanks. I love that Discourse continues to improve and maintain its code!
