Rename "s3 disable cleanup"?


(Dan Dascalescu) #1

Back in February, I’ve set up automatic daily backups on S3, and made sure they worked.

Today I noticed that my server had too many local backups and was running out of space, despite a fix for that behavior submitted in Sep 2015. Needless to say, my Discourse version had been updated many times since Sep 2015.

Is it possible that not having “s3 disable cleanup” checked, might result in Discourse over-deleting backups from S3? (UPDATE: It’s also possible that daily backups just weren’t uploaded to S3 to begin with).

Speaking of logical contortion above, can we rename that option to “Clean up old backups on S3 as well”?