Replacing remote images with local uploaded images issue

evantill · June 3, 2015, 10:43pm

the problem seems to be in this regexp because my link reference is not a number :

discourse/discourse/blob/17d07a8b9a3db9d963f9d7d5bd73504984ef3188/app/jobs/regular/pull_hotlinked_images.rb#L66


      # there are 6 ways to insert an image in a post
      # HTML tag - <img src="http://...">
      raw.gsub!(/src=["']#{escaped_src}["']/i, "src='#{url}'")
      # BBCode tag - [img]http://...[/img]
      raw.gsub!(/\[img\]#{escaped_src}\[\/img\]/i, "[img]#{url}[/img]")
      # Markdown linked image - [![alt](http://...)](http://...)
      raw.gsub!(/\[!\[([^\]]*)\]\(#{escaped_src}\)\]/) { "[<img src='#{url}' alt='#{$1}'>]" }
      # Markdown inline - ![alt](http://...)
      raw.gsub!(/!\[([^\]]*)\]\(#{escaped_src}\)/) { "![#{$1}](#{url})" }
      # Markdown reference - [x]: http://
      raw.gsub!(/\[(\d+)\]: #{escaped_src}/) { "[#{$1}]: #{url}" }
      # Direct link
      raw.gsub!(src, "<img src='#{url}'>")
    end
  rescue => e
    Rails.logger.error("Failed to pull hotlinked image: #{src}\n" + e.message + "\n" + e.backtrace.join("\n"))
  ensure
    # close & delete the temp file
    hotlinked && hotlinked.close!
  end
end

Topic		Replies	Views
System user replaces wrong URL when it downloads local copy of image Bug	16	2584	December 3, 2018
Code block image link gets modified when hotlinked image is downloaded Bug	2	576	September 27, 2023
Upload button remote external image URL field not showing Feature	6	999	December 14, 2021
Images posted via HTTP URL are not being displayed until downloaded to local Bug	17	2016	January 24, 2019
How to disable links turn upload? Support	12	665	January 28, 2023

Replacing remote images with local uploaded images issue

Related topics