For the past some days, when I try to run tests locally, I am getting this error: $ bundle exec rake autospec ... An error occurred while loading ./spec/components/discourse_redis_spec.rb. Failure/Error: describe DiscourseRedis::Connector do let(:connector) { DiscourseRedis::Connector.n…

It looks like we managed to check in broken specs. I’ve disabled the broken specs in this commit: https://github.com/discourse/discourse/commit/b1114b9a20343525c805d7339bd64954965a12f9 But we have two follow up items: Fix the broken specs Make sure we can’t check these in again in the future.

Thanks for looking at this! Did the broken specs land on tests-passed because of intermittent problems? I pulled, and on ac9577bcc7b69593bcdd204368d35492fc0cee15 I’m still seeing exactly the same error locally. So probably more than one problem. :confused:

Sorry, my bad. I forgot to push :facepalm: I’ve updated the previous post with the correct commit. And yes it means broken tests made it into tests-passed. Fortunately Discourse itself is fine - it’s the tests that need to be updated not any bugs in our application. Still, we are going to stop this…

Been there done that! Tests are now happily running. Sorry I didn’t ask earlier. I know I’m outside the mainstream Discourse developer since I’m working on Fedora not Ubuntu, so I have a bias to assume there’s some environmental variant on my machine that is just different. Thanks for unlocking my …

I see there is disagreement about disabling those tests from commit 25db91e35180b2707ca4a9f7ffd173823f86f18d reverting you. But it’s not because it is followed up by fixing the problem, because I tested at d775338d637d9ef3843acf227a138e8f11352151 which is master and tests-passed as of the moment I …

The tests were meant to be removed and I didn’t catch it because our CI had a bug where it wasn’t falling when it encounters an error. This has been fixed in https://github.com/discourse/discourse/commit/add2a9411e7bb26b133a12bacc11a47c43e6f648

Solicitando ajuda com falha ao encontrar DiscourseRedis::Connector durante testes

Dev

eviltrout (Robin Ward) Junho 22, 2020, 8:36pm 2

Parece que conseguimos enviar specs quebrados. Desabilitei os specs quebrados neste commit:

Mas temos dois itens de acompanhamento:

Corrigir os specs quebrados
Garantir que não possamos enviá-los novamente no futuro.

Tópico		Respostas	Visualizações
RSpec failure about redis Self-hosting	3	1160	29 de Dezembro de 2016
Install discourse on localhost Self-hosting	18	5219	20 de Setembro de 2017
Failing upgrade from Discourse v2.8.13 to v2.8.14 Self-hosting	2	899	20 de Janeiro de 2023
Upgrade to 3.0.2: NameError: undefined method `call' for class `Redis::Client' (with a "fix") Self-hosting unsupported-install	11	2504	23 de Junho de 2023
Redis Error after update Self-hosting	9	2513	5 de Março de 2022

Solicitando ajuda com falha ao encontrar DiscourseRedis::Connector durante testes

Tópicos relacionados