Restore Mailing List Mode Daily Summary

Customization Plugin
42

It doesn’t disable the digest but it does provide another option.

Exactly! If you’re limiting what goes out in the summary, it now becomes a digest. Which is the default setup in Discourse.

2개의 좋아요
43

hi @joebuhlig and @pfaffman,

thanks for your replies. but i don’t really get it and maybe you can help me out:

what settings would I need to change to change the current behaviour (ALL topics are included in the daily summary even if the reached the user already during the day because the watch the category)?

thanks in advance,
etienne

44

If I understand correctly, all you need to do is turn off the mailing-list-mode-daily-summary plugin.

The thiing is that the summary might not include ALL of the posts for the day, it chooses just the top 5 or something. You can see what the normal summary looks like at (something like) /admin → email → summary.

1개의 좋아요
45

ah - now i get what you are telling me.

as we need ALL messages to get to our users in the daily summary using the build-in function is not an option. it does not send out all messages.

thats why we are using the mailing-list-mode-daily-summary plugin in the first place.

but now we are getting comments from users about getting messages twice: first as mail during the day because they are watching a topic and then later in the mlm-daily-summary again.

but probably it is not consistent with the idea of a daily SUMMARY to exclude certain messages (that have been send to the user already). so users have to get used to getting things twice i guess.

46

If your users watch the categories that they want they will get all of the messages. They do get each one individually rather than a single message with all of them.

People who watch a category or visit the site regularly don’t need mailing list mode or the plugin.

47

Sounds like you have a conflict between the staff’s desires and the users’ desires. Staff wants everyone to see everything, but the users only want to see a summary.

I’m guessing you’ll need to rectify that discrepancy first.

2개의 좋아요
48

yes, you are right @joebuhlig. we’ll decide on that in the team.

as for your proposal of paying 200$ for the bugfixes: we are discussing that tomorrow in a team-meeting. will let you know.

2개의 좋아요
49

hi @joebuhlig,

sorry - i forgot to tell you earlier: i couldnt bet through with my proposal of paying you guys for fixing the bug. so we would wait for you and your team to find time to fix it.

we are looking forward to seeing the bug fixed.

best, etienne

50

Hi @joebuhlig and others who use this plugin – Is anyone else having issues with this plugin as of the 2.3.0 version of discourse? When our host updated us to 2.3.0 a couple of weeks ago, our daily emails stopped being emailed. And also when I visit a user’s email preferences screen, the checkbox for this email option refuses to be saved. You can click it and Save but then when you reload, it’s unchecked. Just curious if anyone has found a way to fix these issues. Thanks so much if anyone has any insight!

1개의 좋아요
51

hi leah, check my earlier post from jan 29 and check if your problem might also be related to the entry in user_custom_fields? greetings, etienne

1개의 좋아요
52

I have a few updates & I’d love to hear from anyone else using this plugin as to how it’s working for you these days. We have hundreds of people subscribed to the daily emails so we’re hopeful to get this plugin working again.

@etienne, thx for sharing your findings with the true/false t/f. We had someone look into this and he said it looked like the code could handle that ok. So for our situation, I’m still confused as to why some users are getting no daily emails and some users are getting the daily emails only every few days. We definitely have new topics and new posts every day so this email should go out every day.

Our wordpress dev (who’s not really a discourse / ruby expert, per se, just someone who was willing to look at the issue) did manage to solve the front end JS error that was causing a problem with the checkbox not being saved.

Another thing that I’m wondering about from anyone who is using this plugin is this – Do you suspect that there are any issues with this plugin crashing and locking tables in a problematic way? We have another mysterious problem with our forum and one theory is that this plugin might causing it due to locked tables that are not getting unlocked but we haven’t figured that out for sure yet.

53

Hey there,

I have.updated my discourse to 2.4.0 beta2. Since then this plugin is broken.

For now my error code in Sidekick is

Jobs::HandledExceptionWrapper: Wrapped NoMethodError: undefined method apply_notification_styles’ for #UserNotifications:0x00007f1437382668`

I hope this plugin will be fixed soon.

54

We’re seeing this too.

55

Probably because we are unifying all the email styling to make emails more theme-able courtesy of @neil.

56

I just rebuilt, so this is with the latest v2.4.2.beta2 Discourse:

We disabled the mlm-daily plugin and emptied the retries queue yesterday. We’re still seeing errors in /logs and retries are still piling up in Sidekiq:

Jobs::HandledExceptionWrapper: Wrapped NoMethodError: undefined method apply_notification_styles’ for #UserNotifications:0x00007f6f971b9168`

Looks like this affects all notifications, not just the daily summaries. Is there a workaround we can implement until the email styling overhaul is done?

Thanks,
Gunnar

57

This is due to a third party plugin you are using. You will need to either get that plugin updated or disable it.

58

We see this in our installation (2.4.0 beta4) as well. Is there anything I need to update to get that fixed?

Additionally, when users try to enable the Mailing List Mode in their own settings, this is saved (at least the UI tells so), but when reopening the settings dialogue, the checkbox is unchecked again. Thus, we cannot get this plugin to send the daily summary mails anymore. I am not sure, if this has anything to do with the Jobs::HandledExceptionWrapper message mentioned above, but I guess not.

Anyhting I could do to fix this?

Dirk

59

Someone needs to update the plugin to solve the problem. You can read the plugin developer howto topics or post in Marketplace if you have a budget.

3개의 좋아요
60

hi @joebuhlig.

are you still willing to work on this plugin, update it for the upcoming discourse-version 2.4 and fix the bug described earlier on a paid basis? if you tell us a price (you named 200$ for fixing the bug earlier this year), we would discuss it in our team.

thanks for letting us know.
etienne

61

서문:

이것은 플러그인의 업데이트라기보다는 핫픽스에 가깝습니다. 새로운 시스템에서 플러그인이 작동하도록 패치하는 것이 아니라, 제거된 일부 기능을 플러그인에 통합하는 것입니다. 미래 지향적이지 않습니다. 또한, Discourse 팀이 일일 요약을 중요한 사용자 유지 기능(이메일을 선호하는 사용자를 위해)이 아닌, 불필요한 특수 사례로 간주한 문제를 해결하지도 않습니다. 더 이상 Discourse를 메일링 리스트의 대안으로 제대로 사용할 수 없으며, 가능하다면 이주를 고려해야 합니다. "문서나 적절한 릴리스 노트는 필요 없다"는 태도도 고쳐지지 않습니다. < /rant>

그럼에도 불구하고, 우리는 이를 프로덕션 환경에서 사용 중이며 작동하는 것 같습니다. 완벽하지는 않지만, 어쨌든 작동합니다.

이메일 흐름을 다시 시작하는 방법

  1. @lkramer의 수정 사항을 구현하세요.
    Restore Mailing List Mode Daily Summary - #52 by lkramer

이제 UI 버튼을 실제로 다시 전환할 수 있습니다.

  1. apply_notification_styles 메서드를 다시 추가하세요.
    engine.rb 파일의 11번째 줄(클래스의 첫 번째 메서드)에 다음 코드를 추가합니다.
 def apply_notification_styles(email)
                   email.html_part.body = Email::Styles.new(email.html_part.body.to_s).tap do |styles|
                   styles.format_basic
                   styles.format_html
                   end.to_html
                   email

원래 함수(전체를 망가뜨린 커밋을 참고하세요)은 styles.format_html 대신 styles.format_notification을 사용했습니다. _notification이 제거되었기 때문에 우리는 단순히 _html을 사용하고 있습니다. 이것이 좋은 아이디어일까요? 아닙니다. 작동하나요? 그렇습니다. 다행히도 다음 업데이트에서 제거되지 않을 가능성이 약간은 있습니다.

  1. 만능 해결책 (Snake oil)

또한 mailing_list.html.erb 전체를 summary-email 클래스를 가진 Div 태그로 감싸고, 설정에서 요약 이메일에 대한 테마 적용을 비활성화했습니다. 처음에는 절박한 시도였을 뿐이며, 어떤 결과도 나오지 않았습니다. 이 부분을 적용하지 않아도 큰 문제가 없을 가능성이 높지만, 다시 깨지지 않는 한 이 엉망진창인 코드를 다시 건드리지 않을 것입니다. 따라서 서식 문제를 겪는다면 이 방법을 시도해 보셔도 좋습니다.

도움이 되기를 바랍니다.

1개의 좋아요