Revision history messes up with quick edits


(Kane York) #1

When making several edits to a post, some within the 5min grace period, it messes up the revision history.

Given this seqence of edits:

A --- B --- C --- D --- E --- F --- -
|_____________|   |_______|   |__|     5-minute edit coalescing grace periods

Currently, the revision history will show:

C → E
E → F

This isn’t much help, because the A → B and B → C changes are lost. The D → E changes aren’t lost, they just moved in a confusing manner.

My desired behavior would be to have the revision history show this:

A → D
D → F


Diffs don't track all changes when edits are made soon after each other
(Régis Hanol) #2

Yeah I’ve noticed it too. It’s on my list though.


(Jeff Atwood) #3

Yep it should behave like Stack Exchange in this regard. Only edits as they existed at the end of grace periods should be considered real visible revisions.


(Kane York) #4

Okay, the real bug is that the D → E changes are lost. C should be the “#1” revision in the pane, E should be the #2, and F the #3.


(Régis Hanol) #5

@riking it took a while but I finally got it :snail:

https://github.com/discourse/discourse/commit/02dd80170a0204656b367c2e3bc9f457166d6c10


(Jeff Atwood) #6


(Jeff Atwood) #7