main ← Arkshine:fix-compat-with-core
opened 09:33PM - 12 Mar 24 UTC
Meta: https://meta.discourse.org/t/right-sidebar-blocks/231067/79?u=arkshine
…Users have reported an issue with the `custom-html` option and their footer disappearing.
The theme component includes a `custom-html` template, while the core also has a `custom-html` component for displaying the custom footer HTML through the `layout` dynamic property (EDIT: there are others places). As a result, the theme's component overrides the layout.
https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/components/custom-html.js
https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/templates/application.hbs#L97-L102
This PR renames the component and uses `block.internalName` for the component name but keeps the `block.name` untouched for compatibility.
Hopefully, the changes make sense!
