# دعم Ruby 3 المتعلق بجيم mocha **URL:** https://meta.discourse.org/t/ruby-3-support-related-to-mocha-gem/205409 **Category:** Development **Created:** [7 أكتوبر 2021، 3:41ص UTC](https://meta.discourse.org/t/ruby-3-support-related-to-mocha-gem/205409 "2021-10-07T03:41:43Z") **Posts on this page:** 5 **Page:** 1
### Author: ![yahonda](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/yahonda/32/234118_2.png) [@yahonda](https://meta.discourse.org/u/yahonda) #### Post date: [7 أكتوبر 2021، 3:41ص UTC](https://meta.discourse.org/t/ruby-3-support-related-to-mocha-gem/205409/1 "2021-10-07T03:41:43Z")
لدي موضوع آخر لدعم Ruby 3. ### خطوات إعادة الإنتاج ```ruby $ bundle exec rspec ./spec/lib/backup_restore/database_restorer_multisite_spec.rb:15 ``` ### النتيجة الفعلية مع Ruby 3.0.2 ```ruby $ ruby -v ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux] $ bundle exec rspec ./spec/lib/backup_restore/database_restorer_multisite_spec.rb:15 Run options: include {:locations=>{"./spec/lib/backup_restore/database_restorer_multisite_spec.rb"=>[15]}} Randomized with seed 43732 F Failures: 1) BackupRestore::DatabaseRestorer#restore database connection reconnects to the correct database Failure/Error: log Discourse::Utils.execute_command( { "SKIP_POST_DEPLOYMENT_MIGRATIONS" => "0", "SKIP_OPTIMIZE_ICONS" => "1", "DISABLE_TRANSLATION_OVERRIDES" => "1" }, "rake", "db:migrate", failure_message: "Failed to migrate database.", chdir: Rails.root ) Mocha::ExpectationError: unexpected invocation: Discourse::Utils.execute_command({"SKIP_POST_DEPLOYMENT_MIGRATIONS" => "0", "SKIP_OPTIMIZE_ICONS" => "1", "DISABLE_TRANSLATION_OVERRIDES" => "1"}, "rake", "db:migrate", {:failure_message => "Failed to migrate database.", :chdir => #}) unsatisfied expectations: - expected exactly once, invoked never: Discourse::Utils.execute_command() satisfied expectations: - expected exactly once, invoked once: BackupRestore.move_tables_between_schemas("public", "backup") - expected at least once, invoked 77 times: Migration::BaseDropper.create_readonly_function(any_parameters) - expected exactly once, invoked once: #.exitstatus(any_parameters) - expected exactly once, invoked once: Process.last_status(any_parameters) - expected exactly twice, invoked twice: #.readline(any_parameters) - expected exactly once, invoked once: IO.popen(any_parameters) # ./lib/backup_restore/database_restorer.rb:138:in `migrate_database' # ./lib/backup_restore/database_restorer.rb:27:in `restore' # ./spec/lib/backup_restore/shared_context_for_backup_restore.rb:59:in `execute_stubbed_restore' # ./spec/lib/backup_restore/database_restorer_multisite_spec.rb:17:in `block (4 levels) in ' # ./spec/rails_helper.rb:279:in `block (2 levels) in ' Finished in 0.28437 seconds (files took 2.37 seconds to load) 1 example, 1 failure Failed examples: rspec ./spec/lib/backup_restore/database_restorer_multisite_spec.rb:15 # BackupRestore::DatabaseRestorer#restore database connection reconnects to the correct database Randomized with seed 43732 $ ``` ### النتيجة الفعلية مع Ruby 2.7.4 ```ruby $ ruby -v ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux] $ bundle exec rspec ./spec/lib/backup_restore/database_restorer_multisite_spec.rb:15 Run options: include {:locations=>{"./spec/lib/backup_restore/database_restorer_multisite_spec.rb"=>[15]}} Randomized with seed 37771 . Finished in 0.63589 seconds (files took 2.63 seconds to load) 1 example, 0 failures Randomized with seed 37771 $ ``` ### ما اكتشفته حتى الآن في الواقع، هذا يتطلب دعمًا آخر لـ Ruby 3 للوسمات الكلماتية (keyword arguments). - تشغيل مع Ruby 2.7.4 مع تفعيل `-w` وإيجاد `warning: Using the last argument as keyword parameters is deprecated` ```ruby $ bundle exec rspec -w ./spec/lib/backup_restore/database_restorer_multisite_spec.rb:15 2>&1 | grep keyword /home/yahonda/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/mocha-1.13.0/lib/mocha/parameters_matcher.rb:13: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call ``` > - إليك إصلاح سريع وقذر مع كود طباعة للتصحيح (debug). ```diff $ git diff 191823e8696881ab8c72948165834eca18315cb3...8141f2f0eca4bedcf59e34f31dd9ca35e39c2a25 diff --git a/lib/mocha/parameters_matcher.rb b/lib/mocha/parameters_matcher.rb index 2b6ed84..26c4a25 100644 --- a/lib/mocha/parameters_matcher.rb +++ b/lib/mocha/parameters_matcher.rb @@ -10,7 +10,11 @@ module Mocha def match?(actual_parameters = []) if @matching_block - @matching_block.call(*actual_parameters) + p actual_parameters + if actual_parameters.last.is_a? Hash + kwargs = actual_parameters.pop + end + @matching_block.call(*actual_parameters, **kwargs) else parameters_match?(actual_parameters) end $ ``` ### النتيجة مع كود mocha المعدل ```ruby $ bundle exec rspec ./spec/lib/backup_restore/database_restorer_multisite_spec.rb:15 Run options: include {:locations=>{"./spec/lib/backup_restore/database_restorer_multisite_spec.rb"=>[15]}} Randomized with seed 27573 [{"SKIP_POST_DEPLOYMENT_MIGRATIONS"=>"0", "SKIP_OPTIMIZE_ICONS"=>"1", "DISABLE_TRANSLATION_OVERRIDES"=>"1"}, "rake", "db:migrate", {:failure_message=>"Failed to migrate database.", :chdir=>#}] . Finished in 0.40263 seconds (files took 2.88 seconds to load) 1 example, 0 failures Randomized with seed 27573 $ ``` قد أحتاج إلى إنشاء حالة دنيا لـ mocha. سيكون موضع تقدير إذا كان لدى أحدكم اقتراحات. ---
### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam) #### Post date: [11 أكتوبر 2021، 4:01ص UTC](https://meta.discourse.org/t/ruby-3-support-related-to-mocha-gem/205409/2 "2021-10-11T04:01:05Z")
نعم، يبدو أنه إصلاح لـ Mocha. هل قمت بفتح تقرير خطأ لهذه المشكلة على GitHub؟ ---
### Author: ![yahonda](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/yahonda/32/234118_2.png) [@yahonda](https://meta.discourse.org/u/yahonda) #### Post date: [11 أكتوبر 2021، 4:16ص UTC](https://meta.discourse.org/t/ruby-3-support-related-to-mocha-gem/205409/3 "2021-10-11T04:16:16Z")
ليس بعد. سأقوم بمزيد من المراجعة لهذا الأمر هذا الأسبوع. ---
### Author: ![yahonda](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/yahonda/32/234118_2.png) [@yahonda](https://meta.discourse.org/u/yahonda) #### Post date: [12 أكتوبر 2021، 11:55ص UTC](https://meta.discourse.org/t/ruby-3-support-related-to-mocha-gem/205409/4 "2021-10-12T11:55:02Z")
لقد وجدت مشكلة مشابهة تم الإبلاغ عنها، وتم شرح حل بديل > > > See: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-k…eyword-arguments-in-ruby-3-0/ > استخدم kwargs بدلاً من \*\*kwargs، عندها ستكون kwargs عبارة عن Hash يمكنك استخدامه في تأكيدك ولن يتم إنشاء أي تحذيرات… تطبيق الحل البديل المقترح يجعل المواصفات الفاشلة خضراء. [https://github.com/yahonda/discourse/commit/356f15b02cb4a0bb869d19adf2a2018d07ee79bf](https://github.com/yahonda/discourse/commit/356f15b02cb4a0bb869d19adf2a2018d07ee79bf) ```diff $ git diff main diff --git a/spec/lib/backup_restore/shared_context_for_backup_restore.rb b/spec/lib/backup_restore/shared_context_for_backup_restore.rb index 2ff78176ea..0fbc8ade15 100644 --- a/spec/lib/backup_restore/shared_context_for_backup_restore.rb +++ b/spec/lib/backup_restore/shared_context_for_backup_restore.rb @@ -33,7 +33,7 @@ shared_context "shared stuff" do end def expect_db_migrate - Discourse::Utils.expects(:execute_command).with do |env, *command, **options| + Discourse::Utils.expects(:execute_command).with do |env, *command, options| env["SKIP_POST_DEPLOYMENT_MIGRATIONS"] == "0" && env["SKIP_OPTIMIZE_ICONS"] == "1" && env["DISABLE_TRANSLATION_OVERRIDES"] == "1" && $ ``` أنا سعيد بفتح طلب سحب (pull request). ---
### Author: ![yahonda](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/yahonda/32/234118_2.png) [@yahonda](https://meta.discourse.org/u/yahonda) #### Post date: [12 أكتوبر 2021، 1:35م UTC](https://meta.discourse.org/t/ruby-3-support-related-to-mocha-gem/205409/5 "2021-10-12T13:35:11Z")
تم فتح [FIX: `BackupRestore::DatabaseRestorer` failures with Ruby 3 by yahonda · Pull Request #14580 · discourse/discourse · GitHub](https://github.com/discourse/discourse/pull/14580)