'Save Changes' button should be disabled while profile picture is still uploading


#1

I just noticed this when changing my profile picture.
You can click ‘Save Changes’ while the image is still uploading. This effectively cancels the image upload (and your changed setting).

It might sound silly but with uploading a relative large image or on a slow connection, it can take unexpectedly long for the image to complete uploading and the user might close the dialog box with the ‘Save Changes’ button already.


(Jeff Atwood) #2

Probably a good idea, though we have had bad results from disabling login buttons in the past. Something for your list @zogstrip.


(Régis Hanol) #3

Thanks for reporting that issue. I just pushed a fix :baby_chick:

https://github.com/discourse/discourse/commit/aa61c6068b0ed059d3abee189ed0e1bb6ee37e15


(Régis Hanol) #4