Saving your profile makes the Banner Topic reappear even though you already dismissed it


(cpradio) #1

If you enable a banner topic, it can reappear when the topic is edited – and that is okay, however it will also reappear if you save your profile (that’s not okay).

Repro steps:
Create a banner topic
Refresh the site
Dismiss it
Refresh the site (verify it is dismissed)
Go to your profile, press Save (you don’t have to change anything)
Go to the homepage
Refresh the site (banner reappears)
Dismiss it again :frowning:

Expected: Saving of profile doesn’t make the banner reappear.


(Jeff Atwood) #2

@zogstrip can you repro this?


(cpradio) #4

Can you add a banner to Try for me and I’ll see if it happens there? I can definitely repro it on https://community.sitepoint.com which is on latest


(Sam Saffron) #5

Confirmed and fixed, good catch

https://github.com/discourse/discourse/commit/0378dca66f3b491ad9e1907e2b9f0a562fed0e07


(Sam Saffron) #6