I merged this PR this week and I am adding these details to the OP:
https://github.com/discourse/discourse/pull/10563
If you want to allow embedding secure images in emails you can configure these site settings:
-
secure_media_allow_embed_images_in_emails: If enabled we will embed secure images in emails instead of redacting them. -
secure_media_max_email_embed_image_size_kb: The cap to the size of the secure image we will embed, defaulting to 1mb, so the email does not become too big. Max is 10mb. Works in tandem withemail_total_attachment_size_limit_kb.
The secure images will be added as email attachments and embedded using the cid: url format because base64 URL support in email clients is still flaky.
If you don’t have secure_media_allow_embed_images_in_emails enabled, or if the images start to exceed the size limits, then this is what you will see in place of secure images (also secure audio and video which is not embedded):
