Selecteren/lang indrukken doet niets in chat op Android

j.jaffeux · 9 mei 2025 om 16:58

Ok merged:

github.com/discourse/discourse

DEV: revert long press changes

main ← jjaffeux:revert-long-press-change

opened 03:38PM - 09 May 25 UTC

jjaffeux

+82 -39

These changes have been made for playwright as it was hard to test a long press …event on playwright given `click` won't trigger `touchstart` even with `isMobile:true` and `hasTouch:true`. You have to use `tap`, but you don't have the `delay` option on tap, so you can't make it a long tap. Sadly this code is apparently not working correctly on Android 15. This commit will revert the modifier to what it was before and is relying on native JS to trigger the fake long press in specs, which seems to work nicely. This commit also attempts to centralize the actions on messages in page objects to avoid code duplication.

That should do it

Topic		Antwoorden	Weergaven
Long-press menu not working in chat Bug reactions , chat	2	65	1 november 2024
Long press emoticon select doesn't work on one Android Bug pr-welcome , no-repro	4	38	28 augustus 2025
When I tap the chat message actions reaction buttons it activate the chat composer too UX mobile , chat , completed	3	318	15 juli 2023
Reacting to a post starts to highlight something UX mobile , reactions , fixed	4	107	31 december 2024
Hover able elements (user status, reactions) UX mobile , chat , completed , user-status	3	446	20 april 2023

Selecteren/lang indrukken doet niets in chat op Android

Gerelateerde topics