Server-side sync_sso rejects valid payloads with 422 "Login Error" when the base64 contains a `+` (triggered by `~` in synced fields)

zogstrip · 24 ביולי,‏ 2026,‏ 2:04pm

Thanks for the report @sweetbeems It’ll be fixed by

github.com/discourse/discourse

FIX: Preserve "+" in server-side sync_sso payloads (#42024)

main ← fix-sync-sso-plus-double-decode

merged 02:28PM - 24 Jul 26 UTC

ZogStriP

+51 -19

Previously, `sync_sso` rebuilt its query string from the already form-decoded `p…arams[:sso]` and let `DiscourseConnect.parse` decode it a second time, so any literal `+` in the base64 payload became a space and a correctly-signed request was rejected with a generic 422 "Login Error". This change rebuilds the query with `Rack::Utils.build_query` — the exact inverse of the `parse_query` the parser runs — so the payload is decoded exactly once. The second commit applies the same reasoning to `CookedPostProcessor#remove_user_ids`, which rebuilt link query strings by hand and corrupted encoded values (e.g. `%26`) when stripping the `u=` param. Reported at https://meta.discourse.org/t/407426.

נושא		תגובות	צפיות
Issues with SSO and '~' character Support	8	188	20 בפברואר,‏ 2025
Watch out for double url encoding of SSO payload SSO	0	1569	28 ביולי,‏ 2019
SSO and e-mail addresses having a plus sign Support	3	2118	14 באפריל,‏ 2021
Registration email address special characters Support	2	501	16 באוגוסט,‏ 2021
Sso login error when return_sso_url is blank Bug	2	1338	15 באוגוסט,‏ 2016

Server-side sync_sso rejects valid payloads with 422 "Login Error" when the base64 contains a `+` (triggered by `~` in synced fields)

נושאים קשורים