Setting DISCOURSE_MAXMIND_LICENSE_KEY breaks docker image/container build

[tgxworld (Alan Tan)]

@mentalstring

/var/www/discourse/lib/discourse_ip_info.rb:48:in `mmdb_download': undefined method `path' for nil:NilClass (NoMethodError)

    filename = File.basename(gz_file.path)

@mentalstring

but including the DISCOURSE_MAXMIND_ACCOUNT_ID made no difference for me as the rebuild still doesn’t finish (with latest stable)

I can’t reproduce this now and I wonder if this is because MaxMind was down?

We will need to add better safe guards for when MaxMind fails to download.

@jomaxro

Edit: It appears that while the rebuild was successful, MaxMind is not functional.

This has been fixed in

FIX: `FinalDestination#get` forwarding `Authorization` header on redirects

[jomaxro (Joshua Rosenfeld)]

Working for me after a rebuild - thanks!

[mentalstring (Paulo)]

@tgxworld

I can’t reproduce this now and I wonder if this is because MaxMind was down?

Not the case for me, as I’ve been having this problem for some weeks now.

Regardless, thank you @Firefishy and @tgxworld for backporting the fix into stable – I just did a rebuild and it’s working again with MaxMind.