# Shift+S - Lose all edits to wiki

**URL:** https://meta.discourse.org/t/shift-s-lose-all-edits-to-wiki/299851
**Category:** Bug
**Tags:** table-builder, keyboard-shortcuts
**Created:** [March 18, 2024, 6:45pm UTC](https://meta.discourse.org/t/shift-s-lose-all-edits-to-wiki/299851 "2024-03-18T18:45:57Z")
**Posts on this page:** 5
**Page:** 1

<div class="post-metadata">

### Author: ![craigrow](https://avatars.discourse-cdn.com/v4/letter/c/f04885/32.png) [@craigrow](https://meta.discourse.org/u/craigrow)
#### Post date: [March 18, 2024, 6:45pm UTC](https://meta.discourse.org/t/shift-s-lose-all-edits-to-wiki/299851/1 "2024-03-18T18:45:57Z")

</div>

[Steps]

1. Open a wiki page for editing.
2. Make some edits.
3. Put an upper case ‘S’ anywhere
4. The Share dialog will open (picture attached).
5. Dismiss the dialog by clicking the X

[Result]

1. All edits made to the wiki are lost.

[Expected]

1. Shift + S should not result in losing my edits.

Note: upon further investigation, this seems to only happen when typing the first character into a cell. For example, “My Show Stopper” will not trigger the dialog. “Showstopper” will.

 ![Screenshot 2024-03-18 at 11.42.22 AM](https://global.discourse-cdn.com/meta/original/4X/f/3/8/f383adf91e93311a705cc2a055e6b7d8ba3f44e8.png)

---

<div class="post-metadata">

### Author: ![JammyDodger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jammydodger/32/254611_2.png) [@JammyDodger](https://meta.discourse.org/u/JammyDodger)
#### Post date: [March 19, 2024, 2:27pm UTC](https://meta.discourse.org/t/shift-s-lose-all-edits-to-wiki/299851/3 "2024-03-19T14:27:14Z")

</div>

Hi @craigrow 🙂

Are you using the table-builder, by any chance? If so, I think I have a repro of what you’re seeing.

- Open table in edit mode
- Enter cell
- Use Shift + s to enter a capital S  
  
- Share modal opens instead and closes table builder edit, losing any changes

I think the keyboard shortcut is being over-eager there. Let me see if I can get someone to take a look. 👍

---

<div class="post-metadata">

### Author: ![craigrow](https://avatars.discourse-cdn.com/v4/letter/c/f04885/32.png) [@craigrow](https://meta.discourse.org/u/craigrow)
#### Post date: [March 19, 2024, 3:51pm UTC](https://meta.discourse.org/t/shift-s-lose-all-edits-to-wiki/299851/7 "2024-03-19T15:51:31Z")

</div>

Yes, that is correct. I click this edit button here.

 ![Screenshot 2024-03-19 at 8.50.58 AM](https://global.discourse-cdn.com/meta/original/4X/a/e/3/ae32ddf8dffca7963421d5eddf77eaa9d616a316.png)

---

<div class="post-metadata">

### Author: ![keegan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/keegan/32/383395_2.png) [@keegan](https://meta.discourse.org/u/keegan)
#### Post date: [March 21, 2024, 7:16pm UTC](https://meta.discourse.org/t/shift-s-lose-all-edits-to-wiki/299851/8 "2024-03-21T19:16:11Z")

</div>

Thanks for submitting this issue @craigrow, this should now be resolved 🎉  
[https://github.com/discourse/discourse/pull/26278](https://github.com/discourse/discourse/pull/26278)

---

<div class="post-metadata">

### Author: ![keegan](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/keegan/32/383395_2.png) [@keegan](https://meta.discourse.org/u/keegan)
#### Post date: [March 23, 2024, 7:17pm UTC](https://meta.discourse.org/t/shift-s-lose-all-edits-to-wiki/299851/9 "2024-03-23T19:17:05Z")

</div>

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.
