Site setting search shows "no results found" inappropriately


(Anton) #1
  1. Open site settings.
  2. Select “Users” tab.
  3. Type “admin” in the search box.

It ends up with GUI like on the image below:

  • On the right side, it says no results.
  • On the left side, it shows there are 2 results.

It looks confusing.


Show relevant setting-categories in admin settings search
(Jeff Atwood) #4

I can confirm this is an issue:


Site settings search broken
(Kane York) #5

I think this is a regression in a refactoring that was done recently to avoid “route flickering” or something?


#6

Uh, bump? The :bug: is still there :frowning:


(Jeff Atwood) #7

Yeah we need to fix this one.


(James Kiesel) #8

It looks like this is a result of being in a particular category when typing in the search results.

So, for example, when a user first hits the ‘Settings’ page, they’re put into the ‘Required’ category:

Then, when they search, they remain in the ‘required’ category, which (accurately) has no results for admin:

But, if the user performs the same search while in the ‘Basic Setup’ category, the results appear as expected:

So the behaviour’s confusing, but maybe not incorrect. Maybe a message change to the effect of ‘No results found in the “required” category; please select another’ or something? Or maybe we pop the user into the ‘all_results’ category when they first start filtering?


(Régis Hanol) #9

Thanks for reporting that, it’s now fixed :rabbit2:

https://github.com/discourse/discourse/commit/25e5031fb154313c34af88a3205082d51d774be2


(Régis Hanol) #10