Small Language-editing Bug

protesqu · March 8, 2019, 11:45am

Hey.

I’m having difficulties in editing the language string ‘replies’. I can’t seem to find the right string to edit, or it’s somehow gone. I’m referring to the ‘replies’ which appears in the notification area when a user receives a private message.

Ideas?

gerhard · March 8, 2019, 12:39pm

That should be embed.replies – I recommend you translate it on Transifex. That way it will be translated for everyone.

protesqu · March 8, 2019, 2:16pm

Thank you. I did try to edit this string but it didn’t work, still doesn’t.

protesqu · March 8, 2019, 9:08pm

I can’t find the ‘embed.replies’ string on Transifex as well.

gerhard · March 8, 2019, 9:14pm

I’m guessing we are talking about Arabic? If so, here’s a direct link: https://www.transifex.com/discourse/discourse-org/translate/#ar/core-server-yml/140679227?q=key%3Aembed.replies

Otherwise change the language on Transifex accordingly.

protesqu · March 8, 2019, 9:23pm

Hebrew

sam · March 12, 2019, 1:42am

Oh my:

github.com/discourse/discourse

app/services/post_alerter.rb

be5e889b1


      
          post = first_unread_post(user, post.topic) || post
          count = unread_count(user, post.topic)
          if count > 1
            I18n.with_locale(user.effective_locale) do
              opts[:display_username] = I18n.t('embed.replies', count: count)
            end
          end

This is so hacky, we got to clean this up and do the localization using these guys:

github.com/discourse/discourse

config/locales/client.en.yml

be5e889b1


      
          notifications:
            tooltip:
              regular:
                one: "1 unseen notification"
                other: "{{count}} unseen notifications"
              message:
                one: "1 unread message"
                other: "{{count}} unread messages"
            title: "notifications of @name mentions, replies to your posts and topics, messages, etc"
            none: "Unable to load notifications at this time."
            empty: "No notifications found."
            more: "view older notifications"
            total_flagged: "total flagged posts"
            mentioned: "<span>{{username}}</span> {{description}}"
            group_mentioned: "<span>{{username}}</span> {{description}}"
            quoted: "<span>{{username}}</span> {{description}}"
            replied: "<span>{{username}}</span> {{description}}"
            posted: "<span>{{username}}</span> {{description}}"
            edited: "<span>{{username}}</span> {{description}}"
            liked: "<span>{{username}}</span> {{description}}"

This file has been truncated. show original

And stop using a “pretend” username which is broken when you switch locales (cause its baked into the notification)

@gerhard can you clean this up and do the localization here instead:

discourse/app/assets/javascripts/discourse/widgets/notification-item.js.es6 at be5e889b1b55de148b32ae864390a585e027b1ec · discourse/discourse · GitHub

Topic		Replies	Views
Can find "replies" string in the texts to translate Support	4	796	March 12, 2019
Mislocalization of "x replies" in notifications Bug	2	1308	January 29, 2015
Translation missing for Reply Support	6	1655	February 28, 2017
Notification error Bug	14	1686	September 14, 2017
Translate some Entries Support	4	2155	January 25, 2016

Small Language-editing Bug

AI-generated summary

Related topics