# Something missing in "Select images or files from your device ()"?

**URL:** https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708
**Category:** Bug
**Created:** [October 20, 2015, 5:21am UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708 "2015-10-20T05:21:42Z")
**Posts on this page:** 7
**Page:** 1

<div class="post-metadata">

### Author: ![dandv](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dandv/32/169779_2.png) [@dandv](https://meta.discourse.org/u/dandv)
#### Post date: [October 20, 2015, 5:21am UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708/1 "2015-10-20T05:21:42Z")

</div>

What should be between the parentheses in this message?

 ![](https://global.discourse-cdn.com/meta/original/3X/b/2/b2293affd5145f627e9b8940d9e852b086809ff9.png)

I’m on Discourse v1.5.0.beta2 +83. Chrome 46 on Windows.

---

<div class="post-metadata">

### Author: ![Mittineague](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mittineague/32/114259_2.png) [@Mittineague](https://meta.discourse.org/u/Mittineague)
#### Post date: [October 20, 2015, 5:24am UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708/2 "2015-10-20T05:24:27Z")

</div>

> [@dandv](#):
>
> What should be between the parentheses in this message?

Click the upload icon in the composer menu here and you’ll see the approved file types

> select images or files from your device (.jpg, .jpeg, .png, .gif, .svg, .txt, .ico, .yml, .csv, mp3, json)

---

<div class="post-metadata">

### Author: ![dandv](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dandv/32/169779_2.png) [@dandv](https://meta.discourse.org/u/dandv)
#### Post date: [October 20, 2015, 5:32am UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708/3 "2015-10-20T05:32:48Z")

</div>

Looks like a small bug then. I have my extensions set to `*`:

 ![](https://global.discourse-cdn.com/meta/original/3X/d/5/d51e3f417979a50bba81f9003cbc7acbc99cc09a.png) 

Shouldn’t `*` appear between the parens, or perhaps no parens at all?

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [October 20, 2015, 5:39am UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708/4 "2015-10-20T05:39:38Z")

</div>

Yep small bug for @zogstrip to look at. I would just hide the () part if they specified all file types. (by the way this is very dangerous)

---

<div class="post-metadata">

### Author: ![dandv](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dandv/32/169779_2.png) [@dandv](https://meta.discourse.org/u/dandv)
#### Post date: [October 20, 2015, 5:40am UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708/5 "2015-10-20T05:40:59Z")

</div>

> [@codinghorror](#):
>
> (by the way this is very dangerous)

I’d love to blacklist `.exe`, but that doesn’t seem possible? Users of my forum upload all sorts of custom file formats from various self-tracking apps, and having an inclusive list failed every time someone came up with some data dump from a new app.

Maybe an alternative would be for Discourse to display a short help text in that dialog along the lines of “Please zip any file with an extension not in this list”.

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [October 22, 2015, 6:11pm UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708/6 "2015-10-22T18:11:37Z")

</div>

Here’s the fix 🍏

[https://github.com/discourse/discourse/commit/0ea54e9255d7111ffd18bc9fe052831f641ee614](https://github.com/discourse/discourse/commit/0ea54e9255d7111ffd18bc9fe052831f641ee614)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [October 22, 2015, 8:49pm UTC](https://meta.discourse.org/t/something-missing-in-select-images-or-files-from-your-device/34708/7 "2015-10-22T20:49:01Z")

</div>


