Spam (TL 0 post) is not automatically hidden by TL 4


(cpradio) #1

So it is my understanding that a post flagged by TL 3 when the user is TL 0 will be automatically hidden. However, TL 4 flagging a TL 0 post as Spam does not automatically hide.

Seems related to this code:

Repro Steps:

  1. Change a user to TL 4
  2. Create a new User and create a Post/Topic
  3. As the TL 4 user, Flag the newly created Post/Topic as Spam

Expectations:
Post should be hidden.

Actual:
Post remains visible and the Flag appears in the Admin > Flags area.


(cpradio) #2

Maybe someone can correct me if I’m wrong, but is this as simple as replacing

acting_user.trust_level == TrustLevel[3] &&

With

acting_user.has_trust_level?(TrustLevel[3]) &&

As TL 4 also has TL 3, so I think that would work.


(Dave McClure) #3

I don’t know that code, but sounds like that should work!


(cpradio) #4

Seems it does (at least in my dev environment). @codinghorror, @zogstrip, @sam, is this something you want? I know TL 4 is still “to be determined” but this functionality should continue for TL 4 too, yes?


(Régis Hanol) #5

Go for it :thumbsup:


(cpradio) #6

Sent, thanks.
https://github.com/discourse/discourse/pull/2984


(Régis Hanol) #7