# Spans with role of button.. should be buttons

**URL:** https://meta.discourse.org/t/spans-with-role-of-button-should-be-buttons/337067
**Category:** UX
**Tags:** accessibility
**Created:** [November 19, 2024, 6:31pm UTC](https://meta.discourse.org/t/spans-with-role-of-button-should-be-buttons/337067 "2024-11-19T18:31:15Z")
**Posts on this page:** 5
**Page:** 1

<div class="post-metadata">

### Author: ![king\_laurel](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/king_laurel/32/461779_2.png) [@king\_laurel](https://meta.discourse.org/u/king_laurel)
#### Post date: [November 19, 2024, 6:31pm UTC](https://meta.discourse.org/t/spans-with-role-of-button-should-be-buttons/337067/1 "2024-11-19T18:31:15Z")

</div>

These clickable elements currently have a span with a role of button, can we get them updated to be a `button`?

 ![Screenshot 2024-11-19 at 11.29.33 AM](https://global.discourse-cdn.com/meta/original/4X/c/c/4/cc43db97026d8c69e215e32e07b6b180c9302284.png)

---

<div class="post-metadata">

### Author: ![Moin](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/moin/32/554653_2.png) [@Moin](https://meta.discourse.org/u/Moin)
#### Post date: [November 19, 2024, 6:33pm UTC](https://meta.discourse.org/t/spans-with-role-of-button-should-be-buttons/337067/2 "2024-11-19T18:33:49Z")

</div>

I think someone is already working on it:  
[https://github.com/discourse/discourse/pull/29808](https://github.com/discourse/discourse/pull/29808)

---

<div class="post-metadata">

### Author: ![awesomerobot](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/awesomerobot/32/142900_2.png) [@awesomerobot](https://meta.discourse.org/u/awesomerobot)
#### Post date: [November 19, 2024, 8:52pm UTC](https://meta.discourse.org/t/spans-with-role-of-button-should-be-buttons/337067/4 "2024-11-19T20:52:41Z")

</div>

This has been merged and will be included the next time you update Discourse.

---

<div class="post-metadata">

### Author: ![king\_laurel](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/king_laurel/32/461779_2.png) [@king\_laurel](https://meta.discourse.org/u/king_laurel)
#### Post date: [November 19, 2024, 8:53pm UTC](https://meta.discourse.org/t/spans-with-role-of-button-should-be-buttons/337067/5 "2024-11-19T20:53:18Z")

</div>

sweet, thank you

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [November 19, 2024, 10:34pm UTC](https://meta.discourse.org/t/spans-with-role-of-button-should-be-buttons/337067/6 "2024-11-19T22:34:09Z")

</div>