# SSO login suddenly broke

**URL:** https://meta.discourse.org/t/sso-login-suddenly-broke/28375
**Category:** Bug
**Tags:** sso, discourseconnect
**Created:** [5월 6, 2015, 9:16오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375 "2015-05-06T09:16:28Z")
**Posts on this page:** 11
**Page:** 1

<div class="post-metadata">

### Author: ![Himanshu\_Chhangani](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/himanshu_chhangani/32/40772_2.png) [@Himanshu\_Chhangani](https://meta.discourse.org/u/Himanshu_Chhangani)
#### Post date: [5월 6, 2015, 9:16오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/1 "2015-05-06T09:16:28Z")

</div>

When I try to login into my discourse setup using SSO, i get the following error : -  
**Error updating information, contact site admin discourse**

This is what I am getting in error logs,

```
Job exception: undefined method `length' for nil:NilClass

```

What could have possibly caused this ?  
am on _ **v1.3.0.beta6 +223** _

---

<div class="post-metadata">

### Author: ![limeblast](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/limeblast/32/31296_2.png) [@limeblast](https://meta.discourse.org/u/limeblast)
#### Post date: [5월 6, 2015, 10:09오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/2 "2015-05-06T10:09:01Z")

</div>

Which provider did you use?

One of my users reported issues with GitHub earlier today (which I was able to replicate) but within minutes it appears to have fixed itself.

---

<div class="post-metadata">

### Author: ![Himanshu\_Chhangani](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/himanshu_chhangani/32/40772_2.png) [@Himanshu\_Chhangani](https://meta.discourse.org/u/Himanshu_Chhangani)
#### Post date: [5월 6, 2015, 10:18오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/3 "2015-05-06T10:18:00Z")

</div>

@limeblast  
I’ve setup discourse on my local machine, using ubuntu 14.04.

SSO integration is done with one other site.

It was working fine for 2 months, this issue has come up very recently, i got to know about it today.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [5월 6, 2015, 10:34오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/4 "2015-05-06T10:34:10Z")

</div>

Can you provide a deeper stack trace from the logs?

---

<div class="post-metadata">

### Author: ![Himanshu\_Chhangani](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/himanshu_chhangani/32/40772_2.png) [@Himanshu\_Chhangani](https://meta.discourse.org/u/Himanshu_Chhangani)
#### Post date: [5월 6, 2015, 10:40오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/5 "2015-05-06T10:40:45Z")

</div>

Here is the stack trace.

```
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/treetop-1.4.15/lib/treetop/runtime/compiled_parser.rb:64:in `prepare_to_parse'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/treetop-1.4.15/lib/treetop/runtime/compiled_parser.rb:16:in `parse'
/var/www/discourse/lib/email.rb:12:in `is_valid?'
/var/www/discourse/lib/email.rb:20:in `downcase'
/var/www/discourse/app/models/user.rb:182:in `find_by_email'
/var/www/discourse/app/models/discourse_single_sign_on.rb:84:in `match_email_or_create_user'
/var/www/discourse/app/models/discourse_single_sign_on.rb:51:in `lookup_or_create_user'
/var/www/discourse/app/controllers/session_controller.rb:71:in `sso_login'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/abstract_controller/base.rb:189:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/action_controller/metal/rendering.rb:10:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/callbacks.rb:113:in `call'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/callbacks.rb:113:in `call'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/callbacks.rb:552:in `block (2 levels) in compile'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/callbacks.rb:502:in `call'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/callbacks.rb:502:in `call'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/callbacks.rb:86:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/abstract_controller/callbacks.rb:19:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/action_controller/metal/rescue.rb:29:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/notifications.rb:159:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activesupport-4.1.10/lib/active_support/notifications.rb:159:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/activerecord-4.1.10/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionpack-4.1.10/lib/abstract_controller/base.rb:136:in `process'
/var/www/discourse/vendor/bundle/ruby/2.0.0/gems/actionview-4.1.10/lib/action_view/rendering.rb:30:in `process

```

’  
@codinghorror :- I hope this helps.

---

<div class="post-metadata">

### Author: ![Himanshu\_Chhangani](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/himanshu_chhangani/32/40772_2.png) [@Himanshu\_Chhangani](https://meta.discourse.org/u/Himanshu_Chhangani)
#### Post date: [5월 6, 2015, 11:37오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/7 "2015-05-06T11:37:02Z")

</div>

![](https://global.discourse-cdn.com/meta/original/3X/8/5/85581e8a738498869bc752486505b73c87fb4bfc.png) 

@codinghorror : - this should definitely help

---

<div class="post-metadata">

### Author: ![riking](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/riking/32/170938_2.png) [@riking](https://meta.discourse.org/u/riking)
#### Post date: [5월 6, 2015, 4:22오후 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/8 "2015-05-06T16:22:08Z")

</div>

Looks like the SSO parser is getting a nil email?

---

<div class="post-metadata">

### Author: ![uwe\_keim](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/uwe_keim/32/326762_2.png) [@uwe\_keim](https://meta.discourse.org/u/uwe_keim)
#### Post date: [5월 6, 2015, 5:14오후 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/9 "2015-05-06T17:14:03Z")

</div>

Today github was down for several minutes. Maybe this is a cause?

> <https://twitter.com/githubstatus/status/595913960538447872>

---

<div class="post-metadata">

### Author: ![Himanshu\_Chhangani](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/himanshu_chhangani/32/40772_2.png) [@Himanshu\_Chhangani](https://meta.discourse.org/u/Himanshu_Chhangani)
#### Post date: [5월 7, 2015, 5:41오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/10 "2015-05-07T05:41:46Z")

</div>

Thanx a ton @riking .

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [5월 27, 2015, 4:12오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/11 "2015-05-27T04:12:47Z")

</div>

Improved internal handling for this condition.

[https://github.com/discourse/discourse/commit/693b5234da304fc2a9f4e81d3f471660f55acef1](https://github.com/discourse/discourse/commit/693b5234da304fc2a9f4e81d3f471660f55acef1)

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [5월 27, 2015, 4:12오전 UTC](https://meta.discourse.org/t/sso-login-suddenly-broke/28375/12 "2015-05-27T04:12:49Z")

</div>


